kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ale...@apache.org
Subject [kudu] 02/02: [gutil] fix build on macOS
Date Fri, 08 Mar 2019 19:44:47 GMT
This is an automated email from the ASF dual-hosted git repository.

alexey pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git

commit 701f2f4fc9c0ce002a3f72fcdc537610be4e7ac5
Author: Alexey Serbin <alexey@apache.org>
AuthorDate: Fri Mar 8 10:44:10 2019 -0800

    [gutil] fix build on macOS
    
    The newly-added sysinfo-test consists of scenarios for Linux-specific
    ParseMaxCpuIndex() function.  This function is not implemented on macOS,
    so the sysinfo-test in its current state makes sense only for Linux
    Kudu builds.
    
    This is a follow-up to feebbb2649a659bbd6b2fdcfc6a347eafbccba2b.
    
    Change-Id: I3c954b66534690b2c50e86d15f9c9be9d4ce3ed7
    Reviewed-on: http://gerrit.cloudera.org:8080/12703
    Reviewed-by: Will Berkeley <wdberkeley@gmail.com>
    Tested-by: Kudu Jenkins
---
 src/kudu/gutil/CMakeLists.txt | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/kudu/gutil/CMakeLists.txt b/src/kudu/gutil/CMakeLists.txt
index 5569650..f24a41e 100644
--- a/src/kudu/gutil/CMakeLists.txt
+++ b/src/kudu/gutil/CMakeLists.txt
@@ -70,4 +70,8 @@ ADD_EXPORTABLE_LIBRARY(gutil
 
 add_kudu_test(strings/string_util-test)
 add_kudu_test(strings/numbers-test)
-add_kudu_test(sysinfo-test)
+if (NOT APPLE)
+  # The sysinfo-test consists of scenarios for Linux-specific function
+  # ParseMaxCpuIndex(): that doesn't exist on macOS.
+  add_kudu_test(sysinfo-test)
+endif()


Mime
View raw message