kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From a...@apache.org
Subject [kudu] 02/02: linked_list-test: fix SIGSEGV when leader not found
Date Thu, 07 Mar 2019 21:23:40 GMT
This is an automated email from the ASF dual-hosted git repository.

adar pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git

commit cfef3f6fdb0188bc2fa8c63c4c94ee1a49fa90ea
Author: Adar Dembo <adar@cloudera.com>
AuthorDate: Thu Mar 7 12:25:46 2019 -0800

    linked_list-test: fix SIGSEGV when leader not found
    
    This was observed in the test output of KUDU-2738. It's not the root cause
    for the test flakiness (an "address in use" error killed a tserver), but the
    root cause cascaded into this crash.
    
    Change-Id: I6cbea2fff059608f140ad22043b970ee1cd0caeb
    Reviewed-on: http://gerrit.cloudera.org:8080/12693
    Reviewed-by: Mike Percy <mpercy@apache.org>
    Tested-by: Adar Dembo <adar@cloudera.com>
---
 src/kudu/integration-tests/linked_list-test.cc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/kudu/integration-tests/linked_list-test.cc b/src/kudu/integration-tests/linked_list-test.cc
index 42472d9..9415bdb 100644
--- a/src/kudu/integration-tests/linked_list-test.cc
+++ b/src/kudu/integration-tests/linked_list-test.cc
@@ -221,7 +221,7 @@ TEST_F(LinkedListTest, TestLoadAndVerify) {
     // Check in-memory state with a downed TS. Scans may try other replicas.
     string tablet = (*tablet_replicas_.begin()).first;
     TServerDetails* leader;
-    EXPECT_OK(GetLeaderReplicaWithRetries(tablet, &leader));
+    ASSERT_OK(GetLeaderReplicaWithRetries(tablet, &leader));
     LOG(INFO) << "Killing TS: " << leader->instance_id.permanent_uuid() <<
", leader of tablet: "
         << tablet << " and verifying that we can still read all results";
     ASSERT_OK(ShutdownServerWithUUID(leader->uuid()));
@@ -252,7 +252,7 @@ TEST_F(LinkedListTest, TestLoadAndVerify) {
   if (can_kill_ts) {
     string tablet = (*tablet_replicas_.begin()).first;
     TServerDetails* leader;
-    EXPECT_OK(GetLeaderReplicaWithRetries(tablet, &leader));
+    ASSERT_OK(GetLeaderReplicaWithRetries(tablet, &leader));
     LOG(INFO) << "Killing TS: " << leader->instance_id.permanent_uuid() <<
", leader of tablet: "
         << tablet << " and verifying that we can still read all results";
     ASSERT_OK(ShutdownServerWithUUID(leader->uuid()));


Mime
View raw message