From commits-return-6971-archive-asf-public=cust-asf.ponee.io@kudu.apache.org Mon Feb 11 22:17:01 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 450ED180669 for ; Mon, 11 Feb 2019 23:17:01 +0100 (CET) Received: (qmail 7034 invoked by uid 500); 11 Feb 2019 22:17:00 -0000 Mailing-List: contact commits-help@kudu.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kudu.apache.org Delivered-To: mailing list commits@kudu.apache.org Received: (qmail 7024 invoked by uid 99); 11 Feb 2019 22:17:00 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Feb 2019 22:17:00 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id A9CE28297C; Mon, 11 Feb 2019 22:16:59 +0000 (UTC) Date: Mon, 11 Feb 2019 22:17:01 +0000 To: "commits@kudu.apache.org" Subject: [kudu] 02/02: KUDU-2411: Exclude libz from binary jar on macOS MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit From: mpercy@apache.org In-Reply-To: <154992341911.16649.5793957861740222879@gitbox.apache.org> References: <154992341911.16649.5793957861740222879@gitbox.apache.org> X-Git-Host: gitbox.apache.org X-Git-Repo: kudu X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Rev: 626938ed8b9a5bcfe2c1c4a6be44af81f1eafb6b X-Git-NotificationType: diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated Message-Id: <20190211221659.A9CE28297C@gitbox.apache.org> This is an automated email from the ASF dual-hosted git repository. mpercy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/kudu.git commit 626938ed8b9a5bcfe2c1c4a6be44af81f1eafb6b Author: Mike Percy AuthorDate: Mon Feb 11 12:10:14 2019 -0800 KUDU-2411: Exclude libz from binary jar on macOS macOS ships with a version of libz in /usr/lib so we should use that instead in order to avoid ABI incompatibility with system libraries. This is to address the following error observed when someone with an older macOS version built a binary jar and it was tested on a newer macOS version: dyld: Symbol not found: _inflateValidate Referenced from: /System/Library/Frameworks/ImageIO.framework/Versions/A/Resources/libPng.dylib Expected in: /private/var/folders/80/kr312hd50c16mf7k1xm0fnv80000gp/T/kudu-binary-jar4282159433165606863/kudu-binary-1.9.0-osx-x86_64/bin/../lib/libz.1.dylib in /System/Library/Frameworks/ImageIO.framework/Versions/A/Resources/libPng.dylib Change-Id: I2f0862cd949da1466704011a6f3517eb49418570 Reviewed-on: http://gerrit.cloudera.org:8080/12444 Reviewed-by: Grant Henke Tested-by: Grant Henke --- build-support/mini-cluster/relocate_binaries_for_mini_cluster.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/build-support/mini-cluster/relocate_binaries_for_mini_cluster.py b/build-support/mini-cluster/relocate_binaries_for_mini_cluster.py index c1f24b9..cb6dfef 100755 --- a/build-support/mini-cluster/relocate_binaries_for_mini_cluster.py +++ b/build-support/mini-cluster/relocate_binaries_for_mini_cluster.py @@ -96,7 +96,8 @@ PAT_MACOS_LIB_EXCLUDE = re.compile(r"""(AppleFSCompression$| libobjc| libresolv| libsasl2| - libxar + libxar| + libz )""", re.VERBOSE)