kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mpe...@apache.org
Subject [kudu] 02/02: KUDU-2411: Exclude libz from binary jar on macOS
Date Mon, 11 Feb 2019 22:17:01 GMT
This is an automated email from the ASF dual-hosted git repository.

mpercy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git

commit 626938ed8b9a5bcfe2c1c4a6be44af81f1eafb6b
Author: Mike Percy <mpercy@apache.org>
AuthorDate: Mon Feb 11 12:10:14 2019 -0800

    KUDU-2411: Exclude libz from binary jar on macOS
    
    macOS ships with a version of libz in /usr/lib so we should use that
    instead in order to avoid ABI incompatibility with system libraries.
    
    This is to address the following error observed when someone with an
    older macOS version built a binary jar and it was tested on a newer
    macOS version:
    
      dyld: Symbol not found: _inflateValidate
        Referenced from: /System/Library/Frameworks/ImageIO.framework/Versions/A/Resources/libPng.dylib
        Expected in: /private/var/folders/80/kr312hd50c16mf7k1xm0fnv80000gp/T/kudu-binary-jar4282159433165606863/kudu-binary-1.9.0-osx-x86_64/bin/../lib/libz.1.dylib
       in /System/Library/Frameworks/ImageIO.framework/Versions/A/Resources/libPng.dylib
    
    Change-Id: I2f0862cd949da1466704011a6f3517eb49418570
    Reviewed-on: http://gerrit.cloudera.org:8080/12444
    Reviewed-by: Grant Henke <granthenke@apache.org>
    Tested-by: Grant Henke <granthenke@apache.org>
---
 build-support/mini-cluster/relocate_binaries_for_mini_cluster.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/build-support/mini-cluster/relocate_binaries_for_mini_cluster.py b/build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
index c1f24b9..cb6dfef 100755
--- a/build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
+++ b/build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
@@ -96,7 +96,8 @@ PAT_MACOS_LIB_EXCLUDE = re.compile(r"""(AppleFSCompression$|
                                         libobjc|
                                         libresolv|
                                         libsasl2|
-                                        libxar
+                                        libxar|
+                                        libz
                                        )""",
                                        re.VERBOSE)
 


Mime
View raw message