kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From granthe...@apache.org
Subject [kudu] 02/02: KUDU-2477: highlight primary key in master Web UI
Date Thu, 31 Jan 2019 20:58:47 GMT
This is an automated email from the ASF dual-hosted git repository.

granthenke pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git

commit f167cc686311748648514e07cb77b5a22ae98433
Author: Greg Solovyev <fiddlestring@gmail.com>
AuthorDate: Tue Jan 29 16:55:36 2019 -0800

    KUDU-2477: highlight primary key in master Web UI
    
    This change removes underscore tag and adds a key icon
    in front of column name for primary key columns
    
    Screenshot of master Web UI with this change:
    https://issues.apache.org/jira/secure/attachment/12957161/nocss.png
    
    Change-Id: I3cb876ca0b66a78e82714f503c0e52f21706a8fc
    Reviewed-on: http://gerrit.cloudera.org:8080/12316
    Tested-by: Kudu Jenkins
    Reviewed-by: Adar Dembo <adar@cloudera.com>
    Reviewed-by: Grant Henke <granthenke@apache.org>
---
 www/key.png        | Bin 0 -> 1421 bytes
 www/table.mustache |   6 +++---
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/www/key.png b/www/key.png
new file mode 100644
index 0000000..8fe6738
Binary files /dev/null and b/www/key.png differ
diff --git a/www/table.mustache b/www/table.mustache
index 92093ed..8af9ebd 100644
--- a/www/table.mustache
+++ b/www/table.mustache
@@ -48,9 +48,9 @@ under the License.
     <tbody>
     {{#columns}}
       <tr>
-        <th>{{#is_key}}<u>{{/is_key}}
-          {{name}}
-          {{#is_key}}</u>{{/is_key}}</th>
+        <th>
+          {{#is_key}}<img src="key.png" width=12 height=6 />&nbsp;&nbsp;{{/is_key}}{{name}}
+        </th>
         <td>{{id}}</a></td>
         <td>{{type}}</td>
         <td>{{encoding}}</td>


Mime
View raw message