kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From a...@apache.org
Subject kudu git commit: test: deflake TestRestartWithPendingCommitFromFailedOp
Date Wed, 14 Nov 2018 17:58:08 GMT
Repository: kudu
Updated Branches:
  refs/heads/master 7621a6d5c -> eec20423b


test: deflake TestRestartWithPendingCommitFromFailedOp

The test would fail to create the tablet due to the injected failure,
when it should have really waited until the tablet was bootstrapped
before injecting errors.

The test failed 6/1000 times with stress and with a seed of -922249903.
With the fix, 1000/1000 passed.

This isn't the only source of flakiness in ts_recovery-itest, but it's
something.

Change-Id: Ic76b5f120aee7327f6cee7324b862bb89c5662ab
Reviewed-on: http://gerrit.cloudera.org:8080/11929
Tested-by: Andrew Wong <awong@cloudera.com>
Reviewed-by: Alexey Serbin <aserbin@cloudera.com>
Reviewed-by: Adar Dembo <adar@cloudera.com>


Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/eec20423
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/eec20423
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/eec20423

Branch: refs/heads/master
Commit: eec20423b113392f6901b2c56da5646340ca878b
Parents: 7621a6d
Author: Andrew Wong <awong@cloudera.com>
Authored: Tue Nov 13 19:42:07 2018 -0800
Committer: Adar Dembo <adar@cloudera.com>
Committed: Wed Nov 14 17:57:50 2018 +0000

----------------------------------------------------------------------
 src/kudu/integration-tests/ts_recovery-itest.cc | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kudu/blob/eec20423/src/kudu/integration-tests/ts_recovery-itest.cc
----------------------------------------------------------------------
diff --git a/src/kudu/integration-tests/ts_recovery-itest.cc b/src/kudu/integration-tests/ts_recovery-itest.cc
index b55c1c0..1aa9b17 100644
--- a/src/kudu/integration-tests/ts_recovery-itest.cc
+++ b/src/kudu/integration-tests/ts_recovery-itest.cc
@@ -392,9 +392,6 @@ TEST_P(TsRecoveryITest, TestRestartWithOrphanedReplicates) {
 // successful operations.
 TEST_P(TsRecoveryITest, TestRestartWithPendingCommitFromFailedOp) {
   NO_FATALS(StartClusterOneTs());
-  ASSERT_OK(cluster_->SetFlag(cluster_->tablet_server(0),
-                              "fault_crash_before_append_commit", "0.01"));
-
   // Set up the workload to write many duplicate rows, and with only
   // one operation per batch. This means that by the time we crash
   // it's likely that most of the recently appended commit messages
@@ -409,6 +406,8 @@ TEST_P(TsRecoveryITest, TestRestartWithPendingCommitFromFailedOp) {
   work.set_write_batch_size(1);
   work.set_write_pattern(TestWorkload::INSERT_WITH_MANY_DUP_KEYS);
   work.Setup();
+  ASSERT_OK(cluster_->SetFlag(cluster_->tablet_server(0),
+                              "fault_crash_before_append_commit", "0.01"));
   work.Start();
 
   // Wait for the process to crash due to the injected fault.


Mime
View raw message