kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mpe...@apache.org
Subject [2/2] kudu git commit: docs: Use a non-SSH method of installing Gerrit commit hook
Date Wed, 07 Nov 2018 19:06:18 GMT
docs: Use a non-SSH method of installing Gerrit commit hook

Apparently, contributors in China cannot connect to the Gerrit SSH port.
Because of this, they cannot follow the How to Contribute directions for
installing the Gerrit commit hook.

This patch updates those instructions to use HTTPS instead of SSH for
installing the Gerrit commit hook, which should work for everyone.

Change-Id: Ibdb024aafcd601f740ae73d83c54f9659cc5a3a9
Reviewed-on: http://gerrit.cloudera.org:8080/11896
Reviewed-by: Alexey Serbin <aserbin@cloudera.com>
Reviewed-by: Grant Henke <granthenke@apache.org>
Tested-by: Grant Henke <granthenke@apache.org>

Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/ecdeac7d
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/ecdeac7d
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/ecdeac7d

Branch: refs/heads/master
Commit: ecdeac7d3814ba4785b3ed1ba41aeef7079debdc
Parents: ee817a8
Author: Mike Percy <mpercy@apache.org>
Authored: Tue Nov 6 19:33:02 2018 -0800
Committer: Mike Percy <mpercy@apache.org>
Committed: Wed Nov 7 19:06:01 2018 +0000

 docs/contributing.adoc | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/docs/contributing.adoc b/docs/contributing.adoc
index e182c4e..e22df56 100644
--- a/docs/contributing.adoc
+++ b/docs/contributing.adoc
@@ -63,11 +63,13 @@ git remote add gerrit ssh://<username>@gerrit.cloudera.org:29418/kudu
 . Run the following command to install the
-Gerrit `commit-msg` hook. Use the following command, replacing `<username>` with your
-Github username.
+Gerrit `commit-msg` hook. Use the following command:
-gitdir=$(git rev-parse --git-dir); scp -p -P 29418 <username>@gerrit.cloudera.org:hooks/commit-msg
+cd kudu
+gitdir=$(git rev-parse --git-dir)
+curl -LSsf https://gerrit.cloudera.org/tools/hooks/commit-msg -o ${gitdir}/hooks/commit-msg
+chmod +x ${gitdir}/hooks/commit-msg
 . Be sure you have set the Kudu repository to use `pull --rebase` by default. You

View raw message