kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From danburk...@apache.org
Subject [2/2] kudu git commit: Add missing test dependency for Hive tests
Date Fri, 19 Oct 2018 19:24:11 GMT
Add missing test dependency for Hive tests

The HMS client internally calls into the JobConf class, which is
provided by the org.apache.hadoop.hadoop-mapreduce-client-core artifact.
The HMS only specifies an optional dependency on
hadoop-mapreduce-client-core, so we are forced to depend on it
explicitly.

Change-Id: I33187880247b3fe930ff521b0671345646e0fbf4
Reviewed-on: http://gerrit.cloudera.org:8080/11733
Reviewed-by: Hao Hao <hao.hao@cloudera.com>
Reviewed-by: Andrew Wong <awong@cloudera.com>
Tested-by: Dan Burkert <danburkert@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/b3486d99
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/b3486d99
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/b3486d99

Branch: refs/heads/master
Commit: b3486d99a1e1bb5debef82912728d522f58621b7
Parents: 0a7940d
Author: Dan Burkert <danburkert@apache.org>
Authored: Thu Oct 18 17:18:32 2018 -0700
Committer: Dan Burkert <danburkert@apache.org>
Committed: Fri Oct 19 19:23:54 2018 +0000

----------------------------------------------------------------------
 java/gradle/dependencies.gradle | 1 +
 java/kudu-client/build.gradle   | 4 ++++
 2 files changed, 5 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kudu/blob/b3486d99/java/gradle/dependencies.gradle
----------------------------------------------------------------------
diff --git a/java/gradle/dependencies.gradle b/java/gradle/dependencies.gradle
index 267e452..52a5079 100755
--- a/java/gradle/dependencies.gradle
+++ b/java/gradle/dependencies.gradle
@@ -83,6 +83,7 @@ libs += [
     hadoopClient         : "org.apache.hadoop:hadoop-client:$versions.hadoop",
     hadoopCommon         : "org.apache.hadoop:hadoop-common:$versions.hadoop",
     hadoopMRClientCommon : "org.apache.hadoop:hadoop-mapreduce-client-common:$versions.hadoop",
+    hadoopMRClientCore   : "org.apache.hadoop:hadoop-mapreduce-client-core:$versions.hadoop",
     hamcrestCore         : "org.hamcrest:hamcrest-core:$versions.hamcrest",
     hiveMetastore        : "org.apache.hive:hive-metastore:$versions.hive",
     hiveMetastoreTest    : "org.apache.hive:hive-metastore:$versions.hive:tests",

http://git-wip-us.apache.org/repos/asf/kudu/blob/b3486d99/java/kudu-client/build.gradle
----------------------------------------------------------------------
diff --git a/java/kudu-client/build.gradle b/java/kudu-client/build.gradle
index 363135b..2b99355 100644
--- a/java/kudu-client/build.gradle
+++ b/java/kudu-client/build.gradle
@@ -38,6 +38,10 @@ dependencies {
   testCompile project(":kudu-test-utils")
   testCompile libs.hamcrestCore
   testCompile libs.hiveMetastore
+  // The HMS client relies on the MR client-core artifact for JobConf, but only
+  // specifies it as an optional dependency. Gradle doesn't pull in optional
+  // dependencies, so we have to depend on it directly.
+  testCompile libs.hadoopMRClientCore
   testCompile libs.junit
   testCompile libs.log4j
   testCompile libs.mockitoCore


Mime
View raw message