kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From granthe...@apache.org
Subject [1/5] kudu git commit: Fix flakiness in MultiThreadedRpcTest.TestBlowOutServiceQueue
Date Wed, 17 Oct 2018 20:43:05 GMT
Repository: kudu
Updated Branches:
  refs/heads/master 58ecdd155 -> fbe43129f


Fix flakiness in MultiThreadedRpcTest.TestBlowOutServiceQueue

Commit eded05723e changed the error message returned by Socket::Recv
when EOF is received from the remote. The corresponding string used for
matching in TestBlowOutServiceQueue was not updated, so in rare
circumstances the test would fail because it saw an unexpected error
message.

Change-Id: I952f4a01ecf73de5c92c6b0820b9176dde0a5a8f
Reviewed-on: http://gerrit.cloudera.org:8080/11705
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <adar@cloudera.com>


Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/7072a85c
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/7072a85c
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/7072a85c

Branch: refs/heads/master
Commit: 7072a85c5e0cb872c3369b80903ec5a978e92e1b
Parents: 58ecdd1
Author: Will Berkeley <wdberkeley@gmail.com>
Authored: Tue Oct 16 17:59:41 2018 -0700
Committer: Will Berkeley <wdberkeley@gmail.com>
Committed: Wed Oct 17 04:10:54 2018 +0000

----------------------------------------------------------------------
 src/kudu/rpc/mt-rpc-test.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kudu/blob/7072a85c/src/kudu/rpc/mt-rpc-test.cc
----------------------------------------------------------------------
diff --git a/src/kudu/rpc/mt-rpc-test.cc b/src/kudu/rpc/mt-rpc-test.cc
index 7427850..d349e1d 100644
--- a/src/kudu/rpc/mt-rpc-test.cc
+++ b/src/kudu/rpc/mt-rpc-test.cc
@@ -195,7 +195,7 @@ void IncrementBackpressureOrShutdown(const Status* status, int* backpressure,
in
     ++(*backpressure);
   } else if (msg.find("shutting down") != string::npos) {
     ++(*shutdown);
-  } else if (msg.find("got EOF from remote") != string::npos) {
+  } else if (msg.find("recv got EOF from") != string::npos) {
     ++(*shutdown);
   } else {
     FAIL() << "Unexpected status message: " << msg;


Mime
View raw message