kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ale...@apache.org
Subject [1/2] kudu git commit: [tools] Fix help text for replica_type
Date Fri, 07 Sep 2018 21:08:43 GMT
Repository: kudu
Updated Branches:
  refs/heads/master 257dd585a -> 885d8bdaf


[tools] Fix help text for replica_type

'kudu tablet change_config [add_replica|change_replica_type]' take an
argument for 'replica type', which the help text said had to be "VOTER"
or "NON-VOTER", but actually it has to be "VOTER" or "NON_VOTER",
because it is parsed into an enum by a generated PB function, and the PB
enum names are "VOTER" and "NON_VOTER". This fixes the help text.

Change-Id: Icb43e0eaffbfa17967103c7aebe15ea0a06c5598
Reviewed-on: http://gerrit.cloudera.org:8080/11400
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <aserbin@cloudera.com>


Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/0653dcde
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/0653dcde
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/0653dcde

Branch: refs/heads/master
Commit: 0653dcdebb8a5dbe0463341c8f12bbc5ae14fec8
Parents: 257dd58
Author: Will Berkeley <wdberkeley@gmail.org>
Authored: Fri Sep 7 11:34:44 2018 -0700
Committer: Alexey Serbin <aserbin@cloudera.com>
Committed: Fri Sep 7 20:29:31 2018 +0000

----------------------------------------------------------------------
 src/kudu/tools/tool_action_tablet.cc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kudu/blob/0653dcde/src/kudu/tools/tool_action_tablet.cc
----------------------------------------------------------------------
diff --git a/src/kudu/tools/tool_action_tablet.cc b/src/kudu/tools/tool_action_tablet.cc
index bda4637..da0209b 100644
--- a/src/kudu/tools/tool_action_tablet.cc
+++ b/src/kudu/tools/tool_action_tablet.cc
@@ -242,7 +242,7 @@ unique_ptr<Mode> BuildTabletMode() {
       .AddRequiredParameter({ kTsUuidArg,
                               "UUID of the tablet server that should host the new replica"
})
       .AddRequiredParameter(
-          { kReplicaTypeArg, "New replica's type. Must be VOTER or NON-VOTER."
+          { kReplicaTypeArg, "New replica's type. Must be VOTER or NON_VOTER."
           })
       .Build();
 
@@ -255,7 +255,7 @@ unique_ptr<Mode> BuildTabletMode() {
       .AddRequiredParameter({ kTsUuidArg,
                               "UUID of the tablet server hosting the existing replica" })
       .AddRequiredParameter(
-          { kReplicaTypeArg, "Existing replica's new type. Must be VOTER or NON-VOTER."
+          { kReplicaTypeArg, "Existing replica's new type. Must be VOTER or NON_VOTER."
           })
       .Build();
 


Mime
View raw message