kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From danburk...@apache.org
Subject [1/3] kudu git commit: [master] fix compilation warning of DCHECK_NOTNULL
Date Tue, 11 Sep 2018 22:37:18 GMT
Repository: kudu
Updated Branches:
  refs/heads/master f0716cc52 -> ed60c11a3


[master] fix compilation warning of DCHECK_NOTNULL

Fixed compilation warning in case of RELEASE build:

kudu/master/ts_descriptor.cc:103:18: warning:
    expression result unused [-Wunused-value]
  DCHECK_NOTNULL(location);
                 ^~~~~~~~

This patch does not contain any functional changes.

This is a follow-up to dcc39d53d8c36a3f4896ce4c208b855abee8da83.

Change-Id: I768afd0ec34f8127f66ea33338ca29ec337488c5
Reviewed-on: http://gerrit.cloudera.org:8080/11421
Reviewed-by: Adar Dembo <adar@cloudera.com>
Tested-by: Kudu Jenkins


Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/7856ec91
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/7856ec91
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/7856ec91

Branch: refs/heads/master
Commit: 7856ec9174c16c212ce944983124954fe4d325fa
Parents: f0716cc
Author: Alexey Serbin <aserbin@cloudera.com>
Authored: Tue Sep 11 13:01:17 2018 -0700
Committer: Alexey Serbin <aserbin@cloudera.com>
Committed: Tue Sep 11 20:35:18 2018 +0000

----------------------------------------------------------------------
 src/kudu/master/ts_descriptor.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kudu/blob/7856ec91/src/kudu/master/ts_descriptor.cc
----------------------------------------------------------------------
diff --git a/src/kudu/master/ts_descriptor.cc b/src/kudu/master/ts_descriptor.cc
index a360ccb..409cc85 100644
--- a/src/kudu/master/ts_descriptor.cc
+++ b/src/kudu/master/ts_descriptor.cc
@@ -100,7 +100,7 @@ bool IsValidLocation(const string& location) {
 Status GetLocationFromLocationMappingCmd(const string& cmd,
                                          const string& host,
                                          string* location) {
-  DCHECK_NOTNULL(location);
+  DCHECK(location);
   vector<string> argv = strings::Split(cmd, " ", strings::SkipEmpty());
   if (argv.empty()) {
     return Status::RuntimeError("invalid empty location mapping command");


Mime
View raw message