kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ha...@apache.org
Subject kudu git commit: [thirdparty] minor refactor in build-if-necessary
Date Thu, 06 Sep 2018 23:43:25 GMT
Repository: kudu
Updated Branches:
  refs/heads/master 4fceeae3f -> 257dd585a


[thirdparty] minor refactor in build-if-necessary

This commit does a minor refactor in build-if-necessary.sh to always
display informing message when not rebuilding thirdparty.

Change-Id: I2ca2d8907061c1a4ace06a9f624262313a62f700
Reviewed-on: http://gerrit.cloudera.org:8080/11397
Reviewed-by: Adar Dembo <adar@cloudera.com>
Reviewed-by: Dan Burkert <danburkert@apache.org>
Tested-by: Kudu Jenkins


Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/257dd585
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/257dd585
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/257dd585

Branch: refs/heads/master
Commit: 257dd585a9dfa865a57d961bb4a50c1a19acafa7
Parents: 4fceeae
Author: Hao Hao <hao.hao@cloudera.com>
Authored: Thu Sep 6 15:23:14 2018 -0700
Committer: Hao Hao <hao.hao@cloudera.com>
Committed: Thu Sep 6 23:43:00 2018 +0000

----------------------------------------------------------------------
 thirdparty/build-if-necessary.sh | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kudu/blob/257dd585/thirdparty/build-if-necessary.sh
----------------------------------------------------------------------
diff --git a/thirdparty/build-if-necessary.sh b/thirdparty/build-if-necessary.sh
index ea09380..02546fe 100755
--- a/thirdparty/build-if-necessary.sh
+++ b/thirdparty/build-if-necessary.sh
@@ -76,9 +76,6 @@ if [ -n "$IS_IN_GIT" ]; then
     fi
   fi
 
-  if [ -z "$NEEDS_BUILD" ]; then
-    echo "Not rebuilding thirdparty. No changes since last build."
-  fi
 else
   # If we aren't inside running inside a git repository (e.g. we are
   # part of a source distribution tarball) then we can't use git to find
@@ -102,6 +99,7 @@ else
 fi
 
 if [ -z "$NEEDS_BUILD" ]; then
+  echo "Not rebuilding thirdparty. No changes since last build."
   exit 0
 fi
 


Mime
View raw message