kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From danburk...@apache.org
Subject [3/3] kudu git commit: move KUDU_NO_EXPORT attribute on methods
Date Tue, 11 Sep 2018 22:37:20 GMT
move KUDU_NO_EXPORT attribute on methods

The original location was ineffective due to a bug in older versions of
GCC, [1] appears to be the best tracking issue. Adding the annotation at
the end of the method signature silences the warnings on GCC 4.8, and
maintains symbol hiding as checked with nm.

[1]: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=30361

Change-Id: Id0ebdf97263065e14e7a43cf9fcfa7cb26953f57
Reviewed-on: http://gerrit.cloudera.org:8080/11415
Reviewed-by: Adar Dembo <adar@cloudera.com>
Tested-by: Kudu Jenkins


Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/ed60c11a
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/ed60c11a
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/ed60c11a

Branch: refs/heads/master
Commit: ed60c11a3e2fa78e32edbb4f5d3cf844d23d8f00
Parents: d91a252
Author: Dan Burkert <danburkert@apache.org>
Authored: Mon Sep 10 16:36:13 2018 -0700
Committer: Dan Burkert <danburkert@apache.org>
Committed: Tue Sep 11 22:32:50 2018 +0000

----------------------------------------------------------------------
 src/kudu/client/client.h | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kudu/blob/ed60c11a/src/kudu/client/client.h
----------------------------------------------------------------------
diff --git a/src/kudu/client/client.h b/src/kudu/client/client.h
index bfc2c2b..795aae5 100644
--- a/src/kudu/client/client.h
+++ b/src/kudu/client/client.h
@@ -347,8 +347,8 @@ class KUDU_EXPORT KuduClient : public sp::enable_shared_from_this<KuduClient>
{
   ///   Whether to apply the deletion to external catalogs, such as the Hive Metastore,
   ///   which the Kudu master has been configured to integrate with.
   /// @return Operation status.
-  Status KUDU_NO_EXPORT DeleteTableInCatalogs(const std::string& table_name,
-                                              bool modify_external_catalogs);
+  Status DeleteTableInCatalogs(const std::string& table_name,
+                               bool modify_external_catalogs) KUDU_NO_EXPORT;
 
   /// Create a KuduTableAlterer object.
   ///
@@ -445,8 +445,8 @@ class KUDU_EXPORT KuduClient : public sp::enable_shared_from_this<KuduClient>
{
   /// @param [out] tablet
   ///   Tablet information. The caller takes ownership of the tablet.
   /// @return Status object for the operation.
-  Status KUDU_NO_EXPORT GetTablet(const std::string& tablet_id,
-                                  KuduTablet** tablet);
+  Status GetTablet(const std::string& tablet_id,
+                   KuduTablet** tablet) KUDU_NO_EXPORT;
 
   /// @endcond
 
@@ -547,12 +547,12 @@ class KUDU_EXPORT KuduClient : public sp::enable_shared_from_this<KuduClient>
{
   // @return the configured Hive Metastore URIs on the most recently connected to
   //    leader master, or an empty string if the Hive Metastore integration is not
   //    enabled.
-  std::string KUDU_NO_EXPORT GetHiveMetastoreUris() const;
+  std::string GetHiveMetastoreUris() const KUDU_NO_EXPORT;
 
   // @return the configured Hive Metastore SASL (Kerberos) configuration on the most
   //    recently connected to leader master, or an arbitrary value if the Hive
   //    Metastore integration is not enabled.
-  bool KUDU_NO_EXPORT GetHiveMetastoreSaslEnabled() const;
+  bool GetHiveMetastoreSaslEnabled() const KUDU_NO_EXPORT;
 
   // @return a unique ID which identifies the Hive Metastore instance, if the
   //    cluster is configured with the Hive Metastore integration, or an
@@ -561,7 +561,7 @@ class KUDU_EXPORT KuduClient : public sp::enable_shared_from_this<KuduClient>
{
   // @note this is provided on a best-effort basis, as not all Hive Metastore
   //    versions which Kudu is compatible with include the necessary APIs. See
   //    HIVE-16452 for more info.
-  std::string KUDU_NO_EXPORT GetHiveMetastoreUuid() const;
+  std::string GetHiveMetastoreUuid() const KUDU_NO_EXPORT;
 
  private:
   class KUDU_NO_EXPORT Data;
@@ -1214,7 +1214,7 @@ class KUDU_EXPORT KuduTableAlterer {
   /// @param [in] modify_external_catalogs
   ///   Whether to apply the alteration to external catalogs.
   /// @return Raw pointer to this alterer object.
-  KuduTableAlterer* KUDU_NO_EXPORT modify_external_catalogs(bool modify_external_catalogs);
+  KuduTableAlterer* modify_external_catalogs(bool modify_external_catalogs) KUDU_NO_EXPORT;
 
   /// @return Status of the ALTER TABLE operation. The return value
   ///   may indicate an error in the alter operation,


Mime
View raw message