kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jtbirds...@apache.org
Subject kudu git commit: python-client: fix test_scan_rows_string_predicate_and_projection
Date Mon, 18 Jun 2018 16:39:03 GMT
Repository: kudu
Updated Branches:
  refs/heads/master f6668ecac -> a4fd712eb


python-client: fix test_scan_rows_string_predicate_and_projection

Revert unneccesary change to test in test_scanner.py in commit
3bf125f469a2929f7fe20e4e31f073376f37575d. The test
test_scan_rows_string_predicate_and_projection was already working
and using column names is both easier to read and more reliable in
the even of a schema change than the column index numbers.

Change-Id: I12c900c1366fad61f5c04d023d80fea1f488ef19
Reviewed-on: http://gerrit.cloudera.org:8080/10255
Tested-by: Kudu Jenkins
Reviewed-by: David Ribeiro Alves <davidralves@gmail.com>


Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/a4fd712e
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/a4fd712e
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/a4fd712e

Branch: refs/heads/master
Commit: a4fd712eb5418c9262f9ac1dec6a813614777eef
Parents: f6668ec
Author: Andy Stadtler <andy@phdata.io>
Authored: Mon Apr 30 19:36:36 2018 -0500
Committer: Jordan Birdsell <jtbirdsell@apache.org>
Committed: Mon Jun 18 16:31:07 2018 +0000

----------------------------------------------------------------------
 python/kudu/tests/test_scanner.py | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kudu/blob/a4fd712e/python/kudu/tests/test_scanner.py
----------------------------------------------------------------------
diff --git a/python/kudu/tests/test_scanner.py b/python/kudu/tests/test_scanner.py
index a4d0091..ef8cc9c 100644
--- a/python/kudu/tests/test_scanner.py
+++ b/python/kudu/tests/test_scanner.py
@@ -70,12 +70,10 @@ class TestScanner(TestScanBase):
 
     def test_scan_rows_string_predicate_and_projection(self):
         scanner = self.table.scanner()
+        scanner.set_projected_column_names(['key', 'string_val'])
         sv = self.table['string_val']
-
-        scanner.set_projected_column_indexes([0, 2])
         scanner.add_predicates([sv >= 'hello_20',
                                 sv <= 'hello_22'])
-
         scanner.set_fault_tolerant()
         scanner.open()
 


Mime
View raw message