kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From a...@apache.org
Subject [3/3] kudu git commit: build: only call find_package on gperftools if we're going to use it
Date Fri, 18 May 2018 02:52:30 GMT
build: only call find_package on gperftools if we're going to use it

Since commit e0a743d24, TSAN builds emit the following non-fatal warning
when cmake is run:

  -- Could NOT find GOOGLE_PERFTOOLS (missing: TCMALLOC_SHARED_LIB TCMALLOC_STATIC_LIB PROFILER_SHARED_LIB
PROFILER_STATIC_LIB GOOGLE_PERFTOOLS_INCLUDE_DIR)

Moving the find_package() call into the gperftools condition means we won't
try to look for it at all when we're not going to use it.

Change-Id: I76b6c1244cdd5b901b6c23cb56a5613439113773
Reviewed-on: http://gerrit.cloudera.org:8080/10429
Tested-by: Adar Dembo <adar@cloudera.com>
Reviewed-by: Adar Dembo <adar@cloudera.com>


Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/185781f6
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/185781f6
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/185781f6

Branch: refs/heads/master
Commit: 185781f6ced48f1b4a7216034285f772a1efb30b
Parents: 1a7f8c7
Author: Adar Dembo <adar@cloudera.com>
Authored: Sat May 12 14:09:42 2018 -0700
Committer: Adar Dembo <adar@cloudera.com>
Committed: Fri May 18 02:51:56 2018 +0000

----------------------------------------------------------------------
 CMakeLists.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kudu/blob/185781f6/CMakeLists.txt
----------------------------------------------------------------------
diff --git a/CMakeLists.txt b/CMakeLists.txt
index fe6752e..a180a72 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -1122,10 +1122,10 @@ ADD_THIRDPARTY_LIB(krb5
 ##
 ## Disabled with TSAN/ASAN as well as with gold+dynamic linking (see
 ## earlier comment).
-find_package(GPerf REQUIRED)
 if (NOT "${KUDU_USE_ASAN}" AND
     NOT "${KUDU_USE_TSAN}" AND
     NOT ("${KUDU_BUGGY_GOLD}" AND "${KUDU_LINK}" STREQUAL "d"))
+  find_package(GPerf REQUIRED)
   ADD_THIRDPARTY_LIB(tcmalloc
     STATIC_LIB "${TCMALLOC_STATIC_LIB}"
     SHARED_LIB "${TCMALLOC_SHARED_LIB}")


Mime
View raw message