kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From granthe...@apache.org
Subject [2/2] kudu git commit: [java] Add kudu-client dep to kudu-spark-tools
Date Wed, 16 May 2018 17:41:20 GMT
[java] Add kudu-client dep to kudu-spark-tools

We use the kudu-client APIs in kudu-spark-tools
but don’t define it as an explicit dependency.
Using transitive dependencies is a bad practice
but generally doesn’t break anything. However,
the Gradle Intellij integration seams to not find
the kudu-client project dependnecy if it’s not
explicitly listed here.

Change-Id: I6255bedac9781981ae8a937f0dc72afff0fc5ef0
Reviewed-on: http://gerrit.cloudera.org:8080/10425
Tested-by: Grant Henke <granthenke@apache.org>
Reviewed-by: Adar Dembo <adar@cloudera.com>


Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/da9f97e7
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/da9f97e7
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/da9f97e7

Branch: refs/heads/master
Commit: da9f97e7fe492c7493f0c7e1027cb1e701002353
Parents: a587848
Author: Grant Henke <granthenke@apache.org>
Authored: Wed May 16 11:12:09 2018 -0500
Committer: Grant Henke <granthenke@apache.org>
Committed: Wed May 16 17:41:07 2018 +0000

----------------------------------------------------------------------
 java/kudu-spark-tools/build.gradle | 1 +
 java/kudu-spark-tools/pom.xml      | 5 +++++
 2 files changed, 6 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kudu/blob/da9f97e7/java/kudu-spark-tools/build.gradle
----------------------------------------------------------------------
diff --git a/java/kudu-spark-tools/build.gradle b/java/kudu-spark-tools/build.gradle
index 606d8ed..0f2cdd7 100644
--- a/java/kudu-spark-tools/build.gradle
+++ b/java/kudu-spark-tools/build.gradle
@@ -19,6 +19,7 @@ apply plugin: "scala"
 apply from: "$rootDir/gradle/shadow.gradle"
 
 dependencies {
+  compile project(path: ":kudu-client", configuration: "shadow")
   compile project(path: ":kudu-client-tools", configuration: "shadow")
   compile project(path: ":kudu-spark", configuration: "shadow")
 

http://git-wip-us.apache.org/repos/asf/kudu/blob/da9f97e7/java/kudu-spark-tools/pom.xml
----------------------------------------------------------------------
diff --git a/java/kudu-spark-tools/pom.xml b/java/kudu-spark-tools/pom.xml
index 2bc79f0..fbfc2b5 100644
--- a/java/kudu-spark-tools/pom.xml
+++ b/java/kudu-spark-tools/pom.xml
@@ -34,6 +34,11 @@
     <dependencies>
         <dependency>
             <groupId>org.apache.kudu</groupId>
+            <artifactId>kudu-client</artifactId>
+            <version>${project.version}</version>
+        </dependency>
+        <dependency>
+            <groupId>org.apache.kudu</groupId>
             <artifactId>kudu-client-tools</artifactId>
             <version>${project.version}</version>
         </dependency>


Mime
View raw message