kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From granthe...@apache.org
Subject [1/2] kudu git commit: remove logged Kudu URLs
Date Wed, 16 May 2018 17:36:19 GMT
Repository: kudu
Updated Branches:
  refs/heads/master eb81a04db -> 0442d47d5


remove logged Kudu URLs

Previously we would log urls like:
http://kudu.apache.org/releases/1.7.0/docs/...

...to link to pages for common-enough problems with complicated fixes
that warranted some documentation. Given how fragile these URLs can be,
this patch removes such messages, particularly since the URLs are
generated based on `version.txt`, which doesn't necessarily reflect a
proper URL (e.g. if on a SNAPSHOT build) and may be changed by
thirdparty vendors of Kudu.

Change-Id: I357693122d27337183cb85c677a85e7b8d63fe48
Reviewed-on: http://gerrit.cloudera.org:8080/9280
Reviewed-by: Grant Henke <granthenke@apache.org>
Tested-by: Kudu Jenkins


Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/caea85d5
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/caea85d5
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/caea85d5

Branch: refs/heads/master
Commit: caea85d501742a2bf2c4cfc74fead46167d7a5f3
Parents: eb81a04
Author: Andrew Wong <awong@cloudera.com>
Authored: Fri Feb 9 14:21:05 2018 -0800
Committer: Andrew Wong <awong@cloudera.com>
Committed: Wed May 16 17:25:45 2018 +0000

----------------------------------------------------------------------
 src/kudu/server/server_base.cc     | 5 +----
 src/kudu/tserver/tablet_service.cc | 5 +----
 2 files changed, 2 insertions(+), 8 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kudu/blob/caea85d5/src/kudu/server/server_base.cc
----------------------------------------------------------------------
diff --git a/src/kudu/server/server_base.cc b/src/kudu/server/server_base.cc
index f693a73..1a742d1 100644
--- a/src/kudu/server/server_base.cc
+++ b/src/kudu/server/server_base.cc
@@ -81,7 +81,6 @@
 #include "kudu/util/thread.h"
 #include "kudu/util/user.h"
 #include "kudu/util/version_info.h"
-#include "kudu/util/website_util.h"
 
 DEFINE_int32(num_reactor_threads, 4, "Number of libev reactor threads to start.");
 TAG_FLAG(num_reactor_threads, advanced);
@@ -439,9 +438,7 @@ Status ServerBase::Init() {
       // `fs_data_dirs` configuration.
       LOG(INFO) << "To start Kudu with a different FS layout, the `kudu fs "
                    "update_dirs` tool must be run first";
-      return s.CloneAndPrepend(
-          strings::Substitute("FS layout already exists; not overwriting existing layout.
See $0",
-                              KuduDocsTroubleshootingUrl()));
+      return s.CloneAndPrepend("FS layout already exists; not overwriting existing layout");
     }
     RETURN_NOT_OK_PREPEND(s, "Could not create new FS layout");
     s = fs_manager_->Open(&report);

http://git-wip-us.apache.org/repos/asf/kudu/blob/caea85d5/src/kudu/tserver/tablet_service.cc
----------------------------------------------------------------------
diff --git a/src/kudu/tserver/tablet_service.cc b/src/kudu/tserver/tablet_service.cc
index cb4cf12..89dbf95 100644
--- a/src/kudu/tserver/tablet_service.cc
+++ b/src/kudu/tserver/tablet_service.cc
@@ -97,7 +97,6 @@
 #include "kudu/util/status_callback.h"
 #include "kudu/util/trace.h"
 #include "kudu/util/trace_metrics.h"
-#include "kudu/util/website_util.h"
 
 DEFINE_int32(scanner_default_batch_size_bytes, 1024 * 1024,
              "The default size for batches of scan results");
@@ -858,9 +857,7 @@ void TabletServiceImpl::Write(const WriteRequestPB* req,
   double capacity_pct;
   if (process_memory::SoftLimitExceeded(&capacity_pct)) {
     tablet->metrics()->leader_memory_pressure_rejections->Increment();
-    string msg = StringPrintf(
-        "Soft memory limit exceeded (at %.2f%% of capacity). See %s",
-        capacity_pct, KuduDocsTroubleshootingUrl().c_str());
+    string msg = StringPrintf("Soft memory limit exceeded (at %.2f%% of capacity)", capacity_pct);
     if (capacity_pct >= FLAGS_memory_limit_warn_threshold_percentage) {
       KLOG_EVERY_N_SECS(WARNING, 1) << "Rejecting Write request: " << msg <<
THROTTLE_MSG;
     } else {


Mime
View raw message