kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From t...@apache.org
Subject [4/5] kudu git commit: ksck: add virtual destructor to KsckCluster
Date Tue, 17 Apr 2018 23:19:21 GMT
ksck: add virtual destructor to KsckCluster

Fixes the following warning when building with clang-7:

In file included from ../../src/kudu/tools/ksck_remote.cc:18:
In file included from ../../src/kudu/tools/ksck_remote.h:21:
In file included from /usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/memory:82:
In file included from /usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/shared_ptr.h:52:
/usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/shared_ptr_base.h:578:8:
  warning: delete called on non-final 'kudu::tools::RemoteKsckCluster'
  that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor]
              delete __p;

Change-Id: I6f6f0336332289543d103811401b142d383441a0
Reviewed-on: http://gerrit.cloudera.org:8080/10088
Reviewed-by: Will Berkeley <wdberkeley@gmail.com>
Tested-by: Kudu Jenkins


Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/344fea89
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/344fea89
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/344fea89

Branch: refs/heads/master
Commit: 344fea89bab882f5b685ecf9b690516906676178
Parents: 35940a1
Author: Todd Lipcon <todd@apache.org>
Authored: Tue Apr 17 12:09:26 2018 -0700
Committer: Todd Lipcon <todd@apache.org>
Committed: Tue Apr 17 20:04:40 2018 +0000

----------------------------------------------------------------------
 src/kudu/tools/ksck.h | 2 ++
 1 file changed, 2 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kudu/blob/344fea89/src/kudu/tools/ksck.h
----------------------------------------------------------------------
diff --git a/src/kudu/tools/ksck.h b/src/kudu/tools/ksck.h
index c83332f..5bbb6c5 100644
--- a/src/kudu/tools/ksck.h
+++ b/src/kudu/tools/ksck.h
@@ -396,6 +396,8 @@ class KsckTabletServer {
 // Class used to communicate with a cluster.
 class KsckCluster {
  public:
+  virtual ~KsckCluster() = default;
+
   // A list of masters.
   typedef std::vector<std::shared_ptr<KsckMaster>> MasterList;
 


Mime
View raw message