kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From a...@apache.org
Subject [2/2] kudu git commit: verify_jars.pl: ignore gradle-wrapper.jar
Date Wed, 21 Mar 2018 22:43:05 GMT
verify_jars.pl: ignore gradle-wrapper.jar

If you've run the gradle build, the downloaded wrapper is processed and its
classes are flagged as NON_KUDU errors.

I also ran the script on gradle-built artifacts, but they don't appear to be
shaded in the same way as maven-built ones; see KUDU-2365 for more details.

Change-Id: If76c67741658346b0a2b844a765482e8feab8b81
Reviewed-on: http://gerrit.cloudera.org:8080/9745
Reviewed-by: Grant Henke <granthenke@apache.org>
Tested-by: Kudu Jenkins


Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/0fa3cc7c
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/0fa3cc7c
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/0fa3cc7c

Branch: refs/heads/master
Commit: 0fa3cc7cda2aaf7eb4d6763019e42b28fc3f58e6
Parents: ac75b9e
Author: Adar Dembo <adar@cloudera.com>
Authored: Wed Mar 21 15:09:36 2018 -0700
Committer: Adar Dembo <adar@cloudera.com>
Committed: Wed Mar 21 22:42:46 2018 +0000

----------------------------------------------------------------------
 build-support/verify_jars.pl | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kudu/blob/0fa3cc7c/build-support/verify_jars.pl
----------------------------------------------------------------------
diff --git a/build-support/verify_jars.pl b/build-support/verify_jars.pl
index 803db85..1493574 100755
--- a/build-support/verify_jars.pl
+++ b/build-support/verify_jars.pl
@@ -57,8 +57,14 @@ my $dest_dir = $ARGV[0];
 chdir($dest_dir) or die "cannot chdir to destination directory $dest_dir: $!";
 print "Checking jars in directory: " . `pwd`;
 
-chomp(my @jars = `find . -type f -name \*.jar | grep -v build/ | grep -v "tests\.jar" |
-                         grep -v original | grep -v sources\.jar | grep -v javadoc\.jar`);
+# TODO(KUDU-2365): re-include build/ once this bug is fixed.
+chomp(my @jars = `find . -type f -name \*.jar |
+                         grep -v build/ |
+                         grep -v tests\.jar |
+                         grep -v original |
+                         grep -v sources\.jar |
+                         grep -v javadoc\.jar |
+                         grep -v gradle-wrapper.jar`);
 
 my $num_errors = 0;
 


Mime
View raw message