kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aw...@apache.org
Subject [2/5] kudu git commit: tablet: remove an ancient TODO about being able to configure storage attributes
Date Tue, 06 Mar 2018 22:51:07 GMT
tablet: remove an ancient TODO about being able to configure storage attributes

This TODO was implemented years ago but we forgot to remove it.

Change-Id: I0b799c4096fa4deba82fcd2d3a63f83ce8677eaa
Reviewed-on: http://gerrit.cloudera.org:8080/9512
Reviewed-by: Dan Burkert <danburkert@apache.org>
Tested-by: Todd Lipcon <todd@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/72eb86fa
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/72eb86fa
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/72eb86fa

Branch: refs/heads/master
Commit: 72eb86fabe2cb1d145faca07df1200c04bd160df
Parents: d5b3b51
Author: Todd Lipcon <todd@apache.org>
Authored: Tue Mar 6 11:56:52 2018 -0800
Committer: Todd Lipcon <todd@apache.org>
Committed: Tue Mar 6 20:42:12 2018 +0000

----------------------------------------------------------------------
 src/kudu/tablet/diskrowset.cc          | 5 -----
 src/kudu/tablet/multi_column_writer.cc | 5 -----
 2 files changed, 10 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kudu/blob/72eb86fa/src/kudu/tablet/diskrowset.cc
----------------------------------------------------------------------
diff --git a/src/kudu/tablet/diskrowset.cc b/src/kudu/tablet/diskrowset.cc
index f0ce31b..43cb51d 100644
--- a/src/kudu/tablet/diskrowset.cc
+++ b/src/kudu/tablet/diskrowset.cc
@@ -154,11 +154,6 @@ Status DiskRowSetWriter::InitAdHocIndexWriter() {
 
   rowset_metadata_->set_adhoc_index_block(block->id());
 
-  // TODO: allow options to be configured, perhaps on a per-column
-  // basis as part of the schema. For now use defaults.
-  //
-  // Also would be able to set encoding here, or do something smart
-  // to figure out the encoding on the fly.
   cfile::WriterOptions opts;
 
   // Index the composite key by value

http://git-wip-us.apache.org/repos/asf/kudu/blob/72eb86fa/src/kudu/tablet/multi_column_writer.cc
----------------------------------------------------------------------
diff --git a/src/kudu/tablet/multi_column_writer.cc b/src/kudu/tablet/multi_column_writer.cc
index 126b63f..7aa5d03 100644
--- a/src/kudu/tablet/multi_column_writer.cc
+++ b/src/kudu/tablet/multi_column_writer.cc
@@ -63,11 +63,6 @@ Status MultiColumnWriter::Open() {
   for (int i = 0; i < schema_->num_columns(); i++) {
     const ColumnSchema &col = schema_->column(i);
 
-    // TODO: allow options to be configured, perhaps on a per-column
-    // basis as part of the schema. For now use defaults.
-    //
-    // Also would be able to set encoding here, or do something smart
-    // to figure out the encoding on the fly.
     cfile::WriterOptions opts;
 
     // Index all columns by ordinal position, so we can match up


Mime
View raw message