kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mpe...@apache.org
Subject kudu git commit: clang_tidy_gerrit: don't require 'requests' module in local mode
Date Thu, 09 Nov 2017 08:37:53 GMT
Repository: kudu
Updated Branches:
  refs/heads/master 0ca288b91 -> c5fa3ed72


clang_tidy_gerrit: don't require 'requests' module in local mode

My local python installation appears to not have the 'requests' module
which is required by clang_tidy_gerrit to post comments. This should not
prevent me from running the tidy target in local mode.

Change-Id: I511a5b2e58b7d815f90958bc2cf0ec261dfcc1a4
Reviewed-on: http://gerrit.cloudera.org:8080/8501
Tested-by: Todd Lipcon <todd@apache.org>
Reviewed-by: Mike Percy <mpercy@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/c5fa3ed7
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/c5fa3ed7
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/c5fa3ed7

Branch: refs/heads/master
Commit: c5fa3ed7287d6c3c96e5e8686d26573d49e2e120
Parents: 0ca288b
Author: Todd Lipcon <todd@apache.org>
Authored: Wed Nov 8 12:18:47 2017 -0800
Committer: Mike Percy <mpercy@apache.org>
Committed: Thu Nov 9 08:37:44 2017 +0000

----------------------------------------------------------------------
 build-support/clang_tidy_gerrit.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kudu/blob/c5fa3ed7/build-support/clang_tidy_gerrit.py
----------------------------------------------------------------------
diff --git a/build-support/clang_tidy_gerrit.py b/build-support/clang_tidy_gerrit.py
index 8d38781..edaf39e 100755
--- a/build-support/clang_tidy_gerrit.py
+++ b/build-support/clang_tidy_gerrit.py
@@ -24,7 +24,6 @@ import json
 import logging
 import os
 import re
-import requests
 import subprocess
 import sys
 import unittest
@@ -112,6 +111,7 @@ def get_gerrit_revision_url(git_ref):
 
 
 def post_comments(revision_url_base, gerrit_json_obj):
+    import requests
     r = requests.post(revision_url_base + "/review",
                       auth=(GERRIT_USER, GERRIT_PASSWORD),
                       data=json.dumps(gerrit_json_obj),


Mime
View raw message