kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From a...@apache.org
Subject [1/4] kudu git commit: Add missing documentation for reactor latency metric
Date Thu, 26 Oct 2017 16:12:35 GMT
Repository: kudu
Updated Branches:
  refs/heads/master e63d2be62 -> c8603ab77


Add missing documentation for reactor latency metric

Change-Id: I93f18b3f820e2d72648a7142ef2fb344d7db289f
Reviewed-on: http://gerrit.cloudera.org:8080/8383
Reviewed-by: Adar Dembo <adar@cloudera.com>
Tested-by: Kudu Jenkins


Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/69b82b5c
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/69b82b5c
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/69b82b5c

Branch: refs/heads/master
Commit: 69b82b5cc7548519f4474af1d0436ac5ffb8c943
Parents: e63d2be
Author: Todd Lipcon <todd@apache.org>
Authored: Wed Oct 25 12:48:51 2017 -0700
Committer: Todd Lipcon <todd@apache.org>
Committed: Wed Oct 25 20:28:46 2017 +0000

----------------------------------------------------------------------
 src/kudu/rpc/reactor.cc | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kudu/blob/69b82b5c/src/kudu/rpc/reactor.cc
----------------------------------------------------------------------
diff --git a/src/kudu/rpc/reactor.cc b/src/kudu/rpc/reactor.cc
index c9cd92a..617d23d 100644
--- a/src/kudu/rpc/reactor.cc
+++ b/src/kudu/rpc/reactor.cc
@@ -96,7 +96,11 @@ METRIC_DEFINE_histogram(server, reactor_load_percent,
 METRIC_DEFINE_histogram(server, reactor_active_latency_us,
                         "Reactor Thread Active Latency",
                         kudu::MetricUnit::kMicroseconds,
-                        "TODO", 1000000, 2);
+                        "Histogram of the wall clock time for reactor thread wake-ups. "
+                        "The reactor thread is responsible for all network I/O and "
+                        "therefore outliers in this latency histogram directly contribute
"
+                        "to the latency of both inbound and outbound RPCs.",
+                        1000000, 2);
 
 namespace kudu {
 namespace rpc {


Mime
View raw message