kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From danburk...@apache.org
Subject [3/3] kudu git commit: Add support for clang from XCode 9 in macOS
Date Thu, 21 Sep 2017 20:15:45 GMT
Add support for clang from XCode 9 in macOS

Change-Id: Ib636deee77471e60c02e90028a0e5cc0f303b45a
Reviewed-on: http://gerrit.cloudera.org:8080/8119
Reviewed-by: Alexey Serbin <aserbin@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-by: David Ribeiro Alves <davidralves@gmail.com>


Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/315a464c
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/315a464c
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/315a464c

Branch: refs/heads/master
Commit: 315a464c192d04e37f75a84aaceae22cc8f4425f
Parents: 4daa3ce
Author: Dan Burkert <danburkert@apache.org>
Authored: Thu Sep 21 12:24:31 2017 -0700
Committer: Dan Burkert <danburkert@apache.org>
Committed: Thu Sep 21 20:15:26 2017 +0000

----------------------------------------------------------------------
 cmake_modules/CompilerInfo.cmake | 13 +++++++++++++
 1 file changed, 13 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kudu/blob/315a464c/cmake_modules/CompilerInfo.cmake
----------------------------------------------------------------------
diff --git a/cmake_modules/CompilerInfo.cmake b/cmake_modules/CompilerInfo.cmake
index 7e1812c..ff5f789 100644
--- a/cmake_modules/CompilerInfo.cmake
+++ b/cmake_modules/CompilerInfo.cmake
@@ -42,6 +42,19 @@ elseif("${COMPILER_VERSION_FULL}" MATCHES ".*clang-8")
   set(COMPILER_FAMILY "clang")
   set(COMPILER_VERSION "3.8.0svn")
 
+# clang on Mac OS X, XCode 9.
+#
+# TODO(dan): 4.0.0svn is just a guess, because Apple has not (as of the time of
+# writing) released the sources [1]. [2] and [3] are good resources for
+# determining the upstream Clang version as well.
+#
+# [1]: https://opensource.apple.com/
+# [2]: https://gist.github.com/yamaya/2924292
+# [3]: https://gist.github.com/epipping/ef8b02b0cfaec4a5ebf3a57092145a3f
+elseif("${COMPILER_VERSION_FULL}" MATCHES ".*clang-9")
+  set(COMPILER_FAMILY "clang")
+  set(COMPILER_VERSION "4.0.0svn")
+
 # gcc
 elseif("${COMPILER_VERSION_FULL}" MATCHES ".*gcc version.*")
   set(COMPILER_FAMILY "gcc")


Mime
View raw message