kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From a...@apache.org
Subject kudu git commit: KUDU-2083. Decrement running maintenance ops on failed prepare
Date Thu, 07 Sep 2017 02:15:42 GMT
Repository: kudu
Updated Branches:
  refs/heads/branch-1.3.x 6d1081e74 -> a3aacf80e


KUDU-2083. Decrement running maintenance ops on failed prepare

There is currently a bug where we don't decrement the number of
running ops when an op->Prepare() fails. Although rare, when this
bug is hit, it will decrease the number of simultaneous mm ops
that can run until none can, causing the tserver to run OOM.

Change-Id: I8022bcd4c6470dfef2dece0cbefede916a752291
Reviewed-on: http://gerrit.cloudera.org:8080/7610
Reviewed-by: Todd Lipcon <todd@apache.org>
Tested-by: Kudu Jenkins
(cherry picked from commit b365ad0bd6372d459f547da0f1cb82e36148c541)
Reviewed-on: http://gerrit.cloudera.org:8080/7969


Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/a3aacf80
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/a3aacf80
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/a3aacf80

Branch: refs/heads/branch-1.3.x
Commit: a3aacf80ece573047d039fdf825c2895c15a983f
Parents: 6d1081e
Author: David Alves <dralves@apache.org>
Authored: Mon Aug 7 15:42:34 2017 -0700
Committer: Todd Lipcon <todd@apache.org>
Committed: Wed Sep 6 17:06:56 2017 +0000

----------------------------------------------------------------------
 src/kudu/util/maintenance_manager.cc | 1 +
 1 file changed, 1 insertion(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kudu/blob/a3aacf80/src/kudu/util/maintenance_manager.cc
----------------------------------------------------------------------
diff --git a/src/kudu/util/maintenance_manager.cc b/src/kudu/util/maintenance_manager.cc
index eda71e8..0971187 100644
--- a/src/kudu/util/maintenance_manager.cc
+++ b/src/kudu/util/maintenance_manager.cc
@@ -246,6 +246,7 @@ void MaintenanceManager::RunSchedulerThread() {
       LOG_WITH_PREFIX(INFO) << "Prepare failed for " << op->name()
                             << ".  Re-running scheduler.";
       op->running_--;
+      running_ops_--;
       op->cond_->Signal();
       continue;
     }


Mime
View raw message