kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From a...@apache.org
Subject kudu git commit: consensus_peers: don't log tablet copy attempts that were throttled
Date Tue, 29 Aug 2017 21:16:31 GMT
Repository: kudu
Updated Branches:
  refs/heads/branch-1.5.x eadfaaaeb -> 30c98e578


consensus_peers: don't log tablet copy attempts that were throttled

When a tserver with ~6k tablets was killed in a 9 node cluster, another node
started logging ~800 lines of throttled tablet copy messages per second.
This isn't useful and fills up disks.

Change-Id: Ib1c7717847c73870110376d0e7052f0118cb0200
Reviewed-on: http://gerrit.cloudera.org:8080/7868
Tested-by: Adar Dembo <adar@cloudera.com>
Reviewed-by: Hao Hao <hao.hao@cloudera.com>
Reviewed-by: Alexey Serbin <aserbin@cloudera.com>
Reviewed-by: Mike Percy <mpercy@apache.org>
(cherry picked from commit 2d6a2ac7f1255fd6084a42244174eb94d55df57e)
Reviewed-on: http://gerrit.cloudera.org:8080/7877
Tested-by: Kudu Jenkins


Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/30c98e57
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/30c98e57
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/30c98e57

Branch: refs/heads/branch-1.5.x
Commit: 30c98e5780de2530e0dcaa1ba9c9f61ee0063668
Parents: eadfaaa
Author: Adar Dembo <adar@cloudera.com>
Authored: Mon Aug 28 17:44:27 2017 -0700
Committer: Adar Dembo <adar@cloudera.com>
Committed: Tue Aug 29 21:13:34 2017 +0000

----------------------------------------------------------------------
 src/kudu/consensus/consensus_peers.cc | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kudu/blob/30c98e57/src/kudu/consensus/consensus_peers.cc
----------------------------------------------------------------------
diff --git a/src/kudu/consensus/consensus_peers.cc b/src/kudu/consensus/consensus_peers.cc
index 26f6ab4..546f46d 100644
--- a/src/kudu/consensus/consensus_peers.cc
+++ b/src/kudu/consensus/consensus_peers.cc
@@ -389,7 +389,10 @@ void Peer::ProcessTabletCopyResponse() {
   if (success) {
     lock.unlock();
     queue_->NotifyPeerIsResponsive(peer_pb_.permanent_uuid());
-  } else {
+  } else if (!tc_response_.has_error() ||
+              tc_response_.error().code() != TabletServerErrorPB::TabletServerErrorPB::THROTTLED)
{
+    // THROTTLED is a common response after a tserver with many replicas fails;
+    // logging it would generate a great deal of log spam.
     LOG_WITH_PREFIX_UNLOCKED(WARNING) << "Unable to begin Tablet Copy on peer: "
                                       << (controller_.status().ok() ?
                                           SecureShortDebugString(tc_response_) :


Mime
View raw message