kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ale...@apache.org
Subject kudu git commit: [consensus] 'runtime' tag for consensus log FI flags
Date Fri, 23 Jun 2017 18:13:15 GMT
Repository: kudu
Updated Branches:
  refs/heads/master def06d8b8 -> c25d127ad


[consensus] 'runtime' tag for consensus log FI flags

Added the 'runtime' tag for the following consensus log fault-injection
flags:
  * log_inject_latency
  * log_inject_latency_ms_mean
  * log_inject_latency_ms_stddev
  * log_inject_thread_lifecycle_latency_ms
  * fault_crash_before_append_commit

That's just to reflect their current nature "de facto".

Change-Id: I1ee1c17a75121a59b7b02bd104770d808c3536cf
Reviewed-on: http://gerrit.cloudera.org:8080/7233
Reviewed-by: David Ribeiro Alves <davidralves@gmail.com>
Tested-by: Alexey Serbin <aserbin@cloudera.com>


Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/c25d127a
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/c25d127a
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/c25d127a

Branch: refs/heads/master
Commit: c25d127ad3512ed9c9a2565681ffce9de639639f
Parents: def06d8
Author: Alexey Serbin <aserbin@cloudera.com>
Authored: Tue Jun 20 11:10:58 2017 -0700
Committer: Alexey Serbin <aserbin@cloudera.com>
Committed: Fri Jun 23 18:12:32 2017 +0000

----------------------------------------------------------------------
 src/kudu/consensus/log.cc | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kudu/blob/c25d127a/src/kudu/consensus/log.cc
----------------------------------------------------------------------
diff --git a/src/kudu/consensus/log.cc b/src/kudu/consensus/log.cc
index f6dd641..4a149d1 100644
--- a/src/kudu/consensus/log.cc
+++ b/src/kudu/consensus/log.cc
@@ -96,23 +96,32 @@ DEFINE_bool(log_inject_latency, false,
             "If true, injects artificial latency in log sync operations. "
             "Advanced option. Use at your own risk -- has a negative effect "
             "on performance for obvious reasons!");
+TAG_FLAG(log_inject_latency, unsafe);
+TAG_FLAG(log_inject_latency, runtime);
+
 DEFINE_int32(log_inject_latency_ms_mean, 100,
              "The number of milliseconds of latency to inject, on average. "
              "Only takes effect if --log_inject_latency is true");
+TAG_FLAG(log_inject_latency_ms_mean, unsafe);
+TAG_FLAG(log_inject_latency_ms_mean, runtime);
+
 DEFINE_int32(log_inject_latency_ms_stddev, 100,
              "The standard deviation of latency to inject in the log. "
              "Only takes effect if --log_inject_latency is true");
+TAG_FLAG(log_inject_latency_ms_stddev, unsafe);
+TAG_FLAG(log_inject_latency_ms_stddev, runtime);
+
 DEFINE_int32(log_inject_thread_lifecycle_latency_ms, 0,
              "Injection point for random latency during key thread lifecycle transition "
              "points.");
+TAG_FLAG(log_inject_thread_lifecycle_latency_ms, unsafe);
+TAG_FLAG(log_inject_thread_lifecycle_latency_ms, runtime);
+
 DEFINE_double(fault_crash_before_append_commit, 0.0,
               "Fraction of the time when the server will crash just before appending a "
               "COMMIT message to the log. (For testing only!)");
-TAG_FLAG(log_inject_latency, unsafe);
-TAG_FLAG(log_inject_latency_ms_mean, unsafe);
-TAG_FLAG(log_inject_latency_ms_stddev, unsafe);
-TAG_FLAG(log_inject_thread_lifecycle_latency_ms, unsafe);
 TAG_FLAG(fault_crash_before_append_commit, unsafe);
+TAG_FLAG(fault_crash_before_append_commit, runtime);
 
 DEFINE_double(log_inject_io_error_on_append_fraction, 0.0,
               "Fraction of the time when the log will fail to append and return an IOError.
"


Mime
View raw message