Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id EFFCC200C63 for ; Thu, 27 Apr 2017 05:18:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id EECEB160BBB; Thu, 27 Apr 2017 03:18:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 42142160BB7 for ; Thu, 27 Apr 2017 05:18:22 +0200 (CEST) Received: (qmail 78824 invoked by uid 500); 27 Apr 2017 03:18:21 -0000 Mailing-List: contact commits-help@kudu.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kudu.apache.org Delivered-To: mailing list commits@kudu.apache.org Received: (qmail 78768 invoked by uid 99); 27 Apr 2017 03:18:21 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Apr 2017 03:18:21 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 3C002E1835; Thu, 27 Apr 2017 03:18:21 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: jdcryans@apache.org To: commits@kudu.apache.org Date: Thu, 27 Apr 2017 03:18:23 -0000 Message-Id: <185ca8c64e2a4f349fd84ad0425d0a1b@git.apache.org> In-Reply-To: References: X-Mailer: ASF-Git Admin Mailer Subject: [3/3] kudu git commit: Improve unsupported application feature flags error status archived-at: Thu, 27 Apr 2017 03:18:23 -0000 Improve unsupported application feature flags error status It can be helpful to have the exact set of unsupported flags when debugging compatibility issues. Change-Id: Ie59fba2b5ff57a22d16c7b7eca55ab4581e9b64c Reviewed-on: http://gerrit.cloudera.org:8080/6722 Tested-by: Kudu Jenkins Reviewed-by: Jean-Daniel Cryans Project: http://git-wip-us.apache.org/repos/asf/kudu/repo Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/1edaee01 Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/1edaee01 Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/1edaee01 Branch: refs/heads/master Commit: 1edaee01f55f83eb1c8cb5f21daa11c3753d183b Parents: 2be32d5 Author: Dan Burkert Authored: Mon Apr 24 18:28:42 2017 -0700 Committer: Jean-Daniel Cryans Committed: Thu Apr 27 03:17:36 2017 +0000 ---------------------------------------------------------------------- src/kudu/rpc/service_pool.cc | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/kudu/blob/1edaee01/src/kudu/rpc/service_pool.cc ---------------------------------------------------------------------- diff --git a/src/kudu/rpc/service_pool.cc b/src/kudu/rpc/service_pool.cc index d089350..1a23ca9 100644 --- a/src/kudu/rpc/service_pool.cc +++ b/src/kudu/rpc/service_pool.cc @@ -24,11 +24,12 @@ #include "kudu/gutil/gscoped_ptr.h" #include "kudu/gutil/ref_counted.h" +#include "kudu/gutil/strings/join.h" +#include "kudu/gutil/strings/substitute.h" #include "kudu/rpc/inbound_call.h" #include "kudu/rpc/messenger.h" #include "kudu/rpc/service_if.h" #include "kudu/rpc/service_queue.h" -#include "kudu/gutil/strings/substitute.h" #include "kudu/util/logging.h" #include "kudu/util/metrics.h" #include "kudu/util/status.h" @@ -137,7 +138,10 @@ Status ServicePool::QueueInboundCall(gscoped_ptr call) { if (!unsupported_features.empty()) { c->RespondUnsupportedFeature(unsupported_features); - return Status::NotSupported("call requires unsupported application feature flags"); + return Status::NotSupported("call requires unsupported application feature flags", + JoinMapped(unsupported_features, + [] (uint32_t flag) { return std::to_string(flag); }, + ", ")); } TRACE_TO(c->trace(), "Inserting onto call queue");