Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 29249200C3F for ; Wed, 8 Mar 2017 00:51:06 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 27BAE160B68; Tue, 7 Mar 2017 23:51:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 78B8C160B74 for ; Wed, 8 Mar 2017 00:51:05 +0100 (CET) Received: (qmail 12897 invoked by uid 500); 7 Mar 2017 23:51:04 -0000 Mailing-List: contact commits-help@kudu.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kudu.apache.org Delivered-To: mailing list commits@kudu.apache.org Received: (qmail 12880 invoked by uid 99); 7 Mar 2017 23:51:04 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Mar 2017 23:51:04 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 5A15BDFC4A; Tue, 7 Mar 2017 23:51:04 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: danburkert@apache.org To: commits@kudu.apache.org Date: Tue, 07 Mar 2017 23:51:04 -0000 Message-Id: <7129c36acdb4469b9d186bfc05fae622@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [1/2] kudu git commit: [exactly_once_rpc-test] Reduce flakyness of TestExactlyOnceSemanticsGarbageCollection archived-at: Tue, 07 Mar 2017 23:51:06 -0000 Repository: kudu Updated Branches: refs/heads/master 97831eadf -> f24307db4 [exactly_once_rpc-test] Reduce flakyness of TestExactlyOnceSemanticsGarbageCollection This test is failing frequently in the last call with either: Bad status: Network error: Recv() got EOF from remote (error 108) or Bad status: Network error: recv error: Connection reset by peer (error 104) This test waits for "--remember_clients_ttl_ms" to have elapsed before attempting a new call (that should then see that the server no longer remembers the client). The problem is that keepalive is set to be precisely the same amount of time than "--remember_clients_ttl_ms", making it possible that when the client tries the call after the wait, the connection has been closed. This patch fixes this by reducing "--remember_clients_ttl_ms" to half (500 msecs). Change-Id: Idae93a637f3b34bf040e1f523301ccb085e4ca75 Reviewed-on: http://gerrit.cloudera.org:8080/6280 Tested-by: Kudu Jenkins Reviewed-by: Jean-Daniel Cryans Project: http://git-wip-us.apache.org/repos/asf/kudu/repo Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/b6cf6b6b Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/b6cf6b6b Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/b6cf6b6b Branch: refs/heads/master Commit: b6cf6b6b877062f2888d94493abe9c3bf97a29a5 Parents: 97831ea Author: David Alves Authored: Mon Mar 6 18:10:17 2017 -0800 Committer: Jean-Daniel Cryans Committed: Tue Mar 7 18:17:17 2017 +0000 ---------------------------------------------------------------------- src/kudu/rpc/exactly_once_rpc-test.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/kudu/blob/b6cf6b6b/src/kudu/rpc/exactly_once_rpc-test.cc ---------------------------------------------------------------------- diff --git a/src/kudu/rpc/exactly_once_rpc-test.cc b/src/kudu/rpc/exactly_once_rpc-test.cc index 6941f38..d64f6be 100644 --- a/src/kudu/rpc/exactly_once_rpc-test.cc +++ b/src/kudu/rpc/exactly_once_rpc-test.cc @@ -484,7 +484,7 @@ TEST_F(ExactlyOnceRpcTest, TestExactlyOnceSemanticsWithConcurrentUpdaters) { } TEST_F(ExactlyOnceRpcTest, TestExactlyOnceSemanticsGarbageCollection) { - FLAGS_remember_clients_ttl_ms = 1000; + FLAGS_remember_clients_ttl_ms = 500; FLAGS_remember_responses_ttl_ms = 100; StartServer();