kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From a...@apache.org
Subject kudu git commit: client: remove an unnecessary KUDU_NO_EXPORT
Date Thu, 16 Feb 2017 00:53:55 GMT
Repository: kudu
Updated Branches:
  refs/heads/master 987cbc23f -> 9c2b73290


client: remove an unnecessary KUDU_NO_EXPORT

KuduSchemaBuilder::Data is already declared KUDU_NO_EXPORT in schema.h.

I verified that with this patch KuduSchemaBuilder::Data still isn't listed
in the output of "nm --defined -C -D lib/exported/libkudu_client.so".

Change-Id: Ib11424797401c8d2192b46f92de24e52a1fd8e79
Reviewed-on: http://gerrit.cloudera.org:8080/6019
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <todd@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/9c2b7329
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/9c2b7329
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/9c2b7329

Branch: refs/heads/master
Commit: 9c2b73290fcccfb9cc99634d6a376b1f050ff5a2
Parents: 987cbc2
Author: Adar Dembo <adar@cloudera.com>
Authored: Wed Feb 15 13:08:50 2017 -0800
Committer: Adar Dembo <adar@cloudera.com>
Committed: Thu Feb 16 00:43:44 2017 +0000

----------------------------------------------------------------------
 src/kudu/client/schema.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kudu/blob/9c2b7329/src/kudu/client/schema.cc
----------------------------------------------------------------------
diff --git a/src/kudu/client/schema.cc b/src/kudu/client/schema.cc
index 516dfcd..ce806ca 100644
--- a/src/kudu/client/schema.cc
+++ b/src/kudu/client/schema.cc
@@ -259,7 +259,7 @@ Status KuduColumnSpec::ToColumnSchema(KuduColumnSchema* col) const {
 // KuduSchemaBuilder
 ////////////////////////////////////////////////////////////
 
-class KUDU_NO_EXPORT KuduSchemaBuilder::Data {
+class KuduSchemaBuilder::Data {
  public:
   Data() : has_key_col_names(false) {
   }


Mime
View raw message