kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From danburk...@apache.org
Subject kudu git commit: Remove some unused class members
Date Wed, 25 Jan 2017 19:32:05 GMT
Repository: kudu
Updated Branches:
  refs/heads/master e367b4e0b -> b9aa5dd31


Remove some unused class members

Change-Id: Ia8c7265aa1a690cc0987e634c3292f00b67f9a74
Reviewed-on: http://gerrit.cloudera.org:8080/5782
Reviewed-by: Dan Burkert <danburkert@apache.org>
Tested-by: Kudu Jenkins


Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/b9aa5dd3
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/b9aa5dd3
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/b9aa5dd3

Branch: refs/heads/master
Commit: b9aa5dd31ae9de4e95627220fc79741eecfd9de2
Parents: e367b4e
Author: Todd Lipcon <todd@apache.org>
Authored: Tue Jan 24 11:36:36 2017 -0800
Committer: Todd Lipcon <todd@apache.org>
Committed: Wed Jan 25 02:10:31 2017 +0000

----------------------------------------------------------------------
 src/kudu/cfile/cfile_reader.cc | 3 +--
 src/kudu/tablet/memrowset.cc   | 1 -
 src/kudu/tablet/memrowset.h    | 4 ----
 src/kudu/tools/ksck.h          | 6 ++----
 4 files changed, 3 insertions(+), 11 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kudu/blob/b9aa5dd3/src/kudu/cfile/cfile_reader.cc
----------------------------------------------------------------------
diff --git a/src/kudu/cfile/cfile_reader.cc b/src/kudu/cfile/cfile_reader.cc
index 11156c3..69affbe 100644
--- a/src/kudu/cfile/cfile_reader.cc
+++ b/src/kudu/cfile/cfile_reader.cc
@@ -253,7 +253,7 @@ namespace {
 // the memory can be released using 'release()'.
 class ScratchMemory {
  public:
-  ScratchMemory() : cache_(nullptr), ptr_(nullptr), size_(-1) {}
+  ScratchMemory() : ptr_(nullptr), size_(-1) {}
   ~ScratchMemory() {
     if (!ptr_) return;
     if (!from_cache_.valid()) {
@@ -316,7 +316,6 @@ class ScratchMemory {
   }
 
  private:
-  BlockCache* cache_;
   BlockCache::PendingEntry from_cache_;
   uint8_t* ptr_;
   int size_;

http://git-wip-us.apache.org/repos/asf/kudu/blob/b9aa5dd3/src/kudu/tablet/memrowset.cc
----------------------------------------------------------------------
diff --git a/src/kudu/tablet/memrowset.cc b/src/kudu/tablet/memrowset.cc
index 04cc100..82b328e 100644
--- a/src/kudu/tablet/memrowset.cc
+++ b/src/kudu/tablet/memrowset.cc
@@ -110,7 +110,6 @@ MemRowSet::MemRowSet(int64_t id,
     tree_(arena_),
     debug_insert_count_(0),
     debug_update_count_(0),
-    has_logged_throttling_(false),
     anchorer_(log_anchor_registry, Substitute("MemRowSet-$0", id_)) {
   CHECK(schema.has_column_ids());
   ANNOTATE_BENIGN_RACE(&debug_insert_count_, "insert count isnt accurate");

http://git-wip-us.apache.org/repos/asf/kudu/blob/b9aa5dd3/src/kudu/tablet/memrowset.h
----------------------------------------------------------------------
diff --git a/src/kudu/tablet/memrowset.h b/src/kudu/tablet/memrowset.h
index dc7e53d..dd438eb 100644
--- a/src/kudu/tablet/memrowset.h
+++ b/src/kudu/tablet/memrowset.h
@@ -376,8 +376,6 @@ class MemRowSet : public RowSet,
 
   std::mutex compact_flush_lock_;
 
-  Atomic32 has_logged_throttling_;
-
   log::MinLogIndexAnchorer anchorer_;
 
   DISALLOW_COPY_AND_ASSIGN(MemRowSet);
@@ -504,8 +502,6 @@ class MemRowSet::Iterator : public RowwiseIterator {
   // Temporary buffer used for RowChangeList projection.
   faststring delta_buf_;
 
-  size_t prepared_count_;
-
   // Temporary local buffer used for seeking to hold the encoded
   // seek target.
   faststring tmp_buf;

http://git-wip-us.apache.org/repos/asf/kudu/blob/b9aa5dd3/src/kudu/tools/ksck.h
----------------------------------------------------------------------
diff --git a/src/kudu/tools/ksck.h b/src/kudu/tools/ksck.h
index 6a61b08..e86cd87 100644
--- a/src/kudu/tools/ksck.h
+++ b/src/kudu/tools/ksck.h
@@ -69,10 +69,9 @@ struct ChecksumOptions {
 // Representation of a tablet replica on a tablet server.
 class KsckTabletReplica {
  public:
-  KsckTabletReplica(const std::string ts_uuid, const bool is_leader)
+  KsckTabletReplica(std::string ts_uuid, bool is_leader)
       : is_leader_(is_leader),
-        is_running_(false),
-        ts_uuid_(ts_uuid) {
+        ts_uuid_(std::move(ts_uuid)) {
   }
 
   const bool& is_leader() const {
@@ -85,7 +84,6 @@ class KsckTabletReplica {
 
  private:
   const bool is_leader_;
-  bool is_running_;
   const std::string ts_uuid_;
   DISALLOW_COPY_AND_ASSIGN(KsckTabletReplica);
 };


Mime
View raw message