kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From danburk...@apache.org
Subject [2/2] kudu git commit: Reduce default client tablet locations cache TTL
Date Wed, 07 Dec 2016 19:49:35 GMT
Reduce default client tablet locations cache TTL

This reduces the default client tablet locations cache TTL from 60 to 5
minutes. This is expected to make default behavior much less surprising
for users who add and drop range partitions, with little impact on
master load or performance.

Change-Id: I3f93005f067ccd2d28b259e9483dd9384c546152
Reviewed-on: http://gerrit.cloudera.org:8080/5397
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <danburkert@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/a70c9050
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/a70c9050
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/a70c9050

Branch: refs/heads/master
Commit: a70c9050069863cf64a1db9ab5ab6da3de4e0504
Parents: bd72a38
Author: Dan Burkert <danburkert@apache.org>
Authored: Tue Dec 6 21:19:36 2016 -0800
Committer: Dan Burkert <danburkert@apache.org>
Committed: Wed Dec 7 19:49:08 2016 +0000

----------------------------------------------------------------------
 .../src/main/java/org/apache/kudu/client/AlterTableOptions.java  | 4 ++--
 python/kudu/client.pyx                                           | 2 +-
 src/kudu/client/client.h                                         | 2 +-
 src/kudu/master/catalog_manager.cc                               | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kudu/blob/a70c9050/java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java
----------------------------------------------------------------------
diff --git a/java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java
b/java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java
index 72c70e7..31617aa 100644
--- a/java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java
+++ b/java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableOptions.java
@@ -141,7 +141,7 @@ public class AlterTableOptions {
    * This client will immediately be able to write and scan the new tablets when the alter
table
    * operation returns success, however other existing clients may have to wait for a timeout
period
    * to elapse before the tablets become visible. This period is configured by the master's
-   * 'table_locations_ttl_ms' flag, and defaults to one hour.
+   * 'table_locations_ttl_ms' flag, and defaults to 5 minutes.
    *
    * @param lowerBound inclusive lower bound, may be empty but not null
    * @param upperBound exclusive upper bound, may be empty but not null
@@ -167,7 +167,7 @@ public class AlterTableOptions {
    * This client will immediately be able to write and scan the new tablets when the alter
table
    * operation returns success, however other existing clients may have to wait for a timeout
period
    * to elapse before the tablets become visible. This period is configured by the master's
-   * 'table_locations_ttl_ms' flag, and defaults to one hour.
+   * 'table_locations_ttl_ms' flag, and defaults to 5 minutes.
    *
    * @param lowerBound lower bound, may be empty but not null
    * @param upperBound upper bound, may be empty but not null

http://git-wip-us.apache.org/repos/asf/kudu/blob/a70c9050/python/kudu/client.pyx
----------------------------------------------------------------------
diff --git a/python/kudu/client.pyx b/python/kudu/client.pyx
index 9492d2e..ab6a70a 100644
--- a/python/kudu/client.pyx
+++ b/python/kudu/client.pyx
@@ -2693,7 +2693,7 @@ cdef class TableAlterer:
         returns success, however other existing clients may have to wait for a
         timeout period to elapse before the tablets become visible. This period
         is configured by the master's 'table_locations_ttl_ms' flag, and
-        defaults to one hour.
+        defaults to 5 minutes.
 
         Parameters
         ----------

http://git-wip-us.apache.org/repos/asf/kudu/blob/a70c9050/src/kudu/client/client.h
----------------------------------------------------------------------
diff --git a/src/kudu/client/client.h b/src/kudu/client/client.h
index 2472254..4030638 100644
--- a/src/kudu/client/client.h
+++ b/src/kudu/client/client.h
@@ -984,7 +984,7 @@ class KUDU_EXPORT KuduTableAlterer {
   ///   Alter() returns success, however other existing clients may have to wait
   ///   for a timeout period to elapse before the tablets become visible. This
   ///   period is configured by the master's 'table_locations_ttl_ms' flag, and
-  ///   defaults to one hour.
+  ///   defaults to 5 minutes.
   ///
   /// @param [in] lower_bound
   ///   The lower bound of the range partition to add. If the row is empty, then

http://git-wip-us.apache.org/repos/asf/kudu/blob/a70c9050/src/kudu/master/catalog_manager.cc
----------------------------------------------------------------------
diff --git a/src/kudu/master/catalog_manager.cc b/src/kudu/master/catalog_manager.cc
index 1e7fb68..d42dc25 100644
--- a/src/kudu/master/catalog_manager.cc
+++ b/src/kudu/master/catalog_manager.cc
@@ -173,7 +173,7 @@ DEFINE_bool(catalog_manager_check_ts_count_for_create_table, true,
             "a table to be created.");
 TAG_FLAG(catalog_manager_check_ts_count_for_create_table, hidden);
 
-DEFINE_int32(table_locations_ttl_ms, 60 * 60 * 1000, // 1 hour
+DEFINE_int32(table_locations_ttl_ms, 5 * 60 * 1000, // 5 minutes
              "Maximum time in milliseconds which clients may cache table locations. "
              "New range partitions may not be visible to existing client instances "
              "until after waiting for the ttl period.");


Mime
View raw message