kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jdcry...@apache.org
Subject [2/2] kudu git commit: [build] Update syntax of gen_version_info.py
Date Wed, 07 Dec 2016 16:43:42 GMT
[build] Update syntax of gen_version_info.py

Got bit by a SyntaxError here while accidentally building Kudu with a
Python3 distro that didn't have the sha module.

Change-Id: Ib37c8438f8bebbf07560224480543c64eb94cd39
Reviewed-on: http://gerrit.cloudera.org:8080/5396
Tested-by: Kudu Jenkins
Reviewed-by: Jean-Daniel Cryans <jdcryans@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/93649c46
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/93649c46
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/93649c46

Branch: refs/heads/master
Commit: 93649c46933980ee2dfccb45a99f0a608da8fbe1
Parents: 75b1c15
Author: Will Berkeley <wdberkeley@gmail.com>
Authored: Wed Dec 7 00:06:44 2016 -0500
Committer: Jean-Daniel Cryans <jdcryans@apache.org>
Committed: Wed Dec 7 16:43:05 2016 +0000

----------------------------------------------------------------------
 build-support/gen_version_info.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kudu/blob/93649c46/build-support/gen_version_info.py
----------------------------------------------------------------------
diff --git a/build-support/gen_version_info.py b/build-support/gen_version_info.py
index 3688e08..5c2c181 100755
--- a/build-support/gen_version_info.py
+++ b/build-support/gen_version_info.py
@@ -81,7 +81,7 @@ def main():
       git_hash = check_output(["git", "rev-parse", "HEAD"]).strip()
       clean_repo = subprocess.call("git diff --quiet && git diff --cached --quiet",
shell=True) == 0
       clean_repo = str(clean_repo).lower()
-    except Exception, e:
+    except Exception:
       # If the git commands failed, we're probably building outside of a git
       # repository.
       logging.info("Build appears to be outside of a git repository... " +


Mime
View raw message