Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C1C6F200BC6 for ; Sun, 20 Nov 2016 19:47:03 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id C0413160B1D; Sun, 20 Nov 2016 18:47:03 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 15E2B160B1B for ; Sun, 20 Nov 2016 19:47:02 +0100 (CET) Received: (qmail 13286 invoked by uid 500); 20 Nov 2016 18:47:02 -0000 Mailing-List: contact commits-help@kudu.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kudu.apache.org Delivered-To: mailing list commits@kudu.apache.org Received: (qmail 13242 invoked by uid 99); 20 Nov 2016 18:47:02 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 20 Nov 2016 18:47:02 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 08D03F17B8; Sun, 20 Nov 2016 18:47:02 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: todd@apache.org To: commits@kudu.apache.org Date: Sun, 20 Nov 2016 18:47:04 -0000 Message-Id: In-Reply-To: <5707f72bf8344035bec61171f8290196@git.apache.org> References: <5707f72bf8344035bec61171f8290196@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [4/4] kudu git commit: Fix flakiness of MiniKDC archived-at: Sun, 20 Nov 2016 18:47:03 -0000 Fix flakiness of MiniKDC We use 'lsof' to find the ephemeral port assigned to the MiniKDC, but we weren't passing the '-P' flag which inhibits the conversion of numeric port numbers to service names. As such, occasionally the MiniKDC would be assigned some port which matches a named service in /etc/services and result in lsof output like: p934 f7 n*:mediabox (mediabox is registered as port 46999) This would cause the port number parsing to fail, making tests ~1% flaky. Passing the '-P' flag inhibits the conversion of port numbers to port names. Change-Id: I88c0459d4b8ce0371f7cdf5cc38879ecc8cbf5ff Reviewed-on: http://gerrit.cloudera.org:8080/5156 Reviewed-by: Jordan Birdsell Tested-by: Kudu Jenkins Project: http://git-wip-us.apache.org/repos/asf/kudu/repo Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/d8ce4389 Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/d8ce4389 Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/d8ce4389 Branch: refs/heads/master Commit: d8ce43893061e7571ac9ea5a2a10b481342ff633 Parents: 06bb52d Author: Todd Lipcon Authored: Sun Nov 20 09:11:06 2016 -0800 Committer: Todd Lipcon Committed: Sun Nov 20 17:45:27 2016 +0000 ---------------------------------------------------------------------- src/kudu/security/test/mini_kdc.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/kudu/blob/d8ce4389/src/kudu/security/test/mini_kdc.cc ---------------------------------------------------------------------- diff --git a/src/kudu/security/test/mini_kdc.cc b/src/kudu/security/test/mini_kdc.cc index 126bcc2..e365dee 100644 --- a/src/kudu/security/test/mini_kdc.cc +++ b/src/kudu/security/test/mini_kdc.cc @@ -253,7 +253,7 @@ Status MiniKdc::WaitForKdcPorts() { RETURN_NOT_OK(GetBinaryPath("lsof", {"/sbin", "/usr/sbin"}, &lsof)); vector cmd = { - lsof, "-wbn", "-Ffn", + lsof, "-wbnP", "-Ffn", "-p", std::to_string(kdc_process_->pid()), "-a", "-i", "4UDP"};