kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From t...@apache.org
Subject [4/4] kudu git commit: Fix flakiness of MiniKDC
Date Sun, 20 Nov 2016 18:47:04 GMT
Fix flakiness of MiniKDC

We use 'lsof' to find the ephemeral port assigned to the MiniKDC, but we
weren't passing the '-P' flag which inhibits the conversion of numeric
port numbers to service names. As such, occasionally the MiniKDC would
be assigned some port which matches a named service in /etc/services and
result in lsof output like:
  p934
  f7
  n*:mediabox
(mediabox is registered as port 46999)

This would cause the port number parsing to fail, making tests ~1%
flaky.

Passing the '-P' flag inhibits the conversion of port numbers to port
names.

Change-Id: I88c0459d4b8ce0371f7cdf5cc38879ecc8cbf5ff
Reviewed-on: http://gerrit.cloudera.org:8080/5156
Reviewed-by: Jordan Birdsell <jtbirdsell@apache.org>
Tested-by: Kudu Jenkins


Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/d8ce4389
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/d8ce4389
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/d8ce4389

Branch: refs/heads/master
Commit: d8ce43893061e7571ac9ea5a2a10b481342ff633
Parents: 06bb52d
Author: Todd Lipcon <todd@apache.org>
Authored: Sun Nov 20 09:11:06 2016 -0800
Committer: Todd Lipcon <todd@apache.org>
Committed: Sun Nov 20 17:45:27 2016 +0000

----------------------------------------------------------------------
 src/kudu/security/test/mini_kdc.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kudu/blob/d8ce4389/src/kudu/security/test/mini_kdc.cc
----------------------------------------------------------------------
diff --git a/src/kudu/security/test/mini_kdc.cc b/src/kudu/security/test/mini_kdc.cc
index 126bcc2..e365dee 100644
--- a/src/kudu/security/test/mini_kdc.cc
+++ b/src/kudu/security/test/mini_kdc.cc
@@ -253,7 +253,7 @@ Status MiniKdc::WaitForKdcPorts() {
   RETURN_NOT_OK(GetBinaryPath("lsof", {"/sbin", "/usr/sbin"}, &lsof));
 
   vector<string> cmd = {
-    lsof, "-wbn", "-Ffn",
+    lsof, "-wbnP", "-Ffn",
     "-p", std::to_string(kdc_process_->pid()),
     "-a", "-i", "4UDP"};
 


Mime
View raw message