kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From danburk...@apache.org
Subject [1/2] kudu git commit: macOS: fix shared_ptr.h includes
Date Mon, 14 Nov 2016 20:32:57 GMT
Repository: kudu
Updated Branches:
  refs/heads/master 7f4aaaf17 -> 637b6c226


macOS: fix shared_ptr.h includes

_LIBCPP_VERSION was not being defined appropriately in
client_samples-test due to header include order.

Change-Id: Iff56316ea55244235f3a44df8e0c3f53da1b35c6
Reviewed-on: http://gerrit.cloudera.org:8080/5037
Reviewed-by: Adar Dembo <adar@cloudera.com>
Tested-by: Kudu Jenkins


Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/e0cfa757
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/e0cfa757
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/e0cfa757

Branch: refs/heads/master
Commit: e0cfa7573ca200d1f016a3053598aa1e7b4290ac
Parents: 7f4aaaf
Author: Dan Burkert <danburkert@apache.org>
Authored: Thu Nov 10 13:35:03 2016 -0800
Committer: Dan Burkert <danburkert@apache.org>
Committed: Mon Nov 14 20:32:31 2016 +0000

----------------------------------------------------------------------
 src/kudu/client/shared_ptr.h | 5 +++++
 1 file changed, 5 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kudu/blob/e0cfa757/src/kudu/client/shared_ptr.h
----------------------------------------------------------------------
diff --git a/src/kudu/client/shared_ptr.h b/src/kudu/client/shared_ptr.h
index 79155e5..ea01131 100644
--- a/src/kudu/client/shared_ptr.h
+++ b/src/kudu/client/shared_ptr.h
@@ -33,7 +33,12 @@
 /// namespace in either case. Clients are encouraged to use these macros in
 /// order to ensure that applications compile universally.
 
+// This include is not used directly, but we need to include some C++ header in
+// order to ensure the _LIBCPP_VERSION macro is defined appropriately.
+#include <string>
+
 #if defined(_LIBCPP_VERSION)
+
 #include <memory>
 
 namespace kudu {


Mime
View raw message