kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From t...@apache.org
Subject kudu git commit: Workaround KUDU-1580: bump negotiation timeout to 15sec
Date Tue, 08 Nov 2016 01:24:08 GMT
Repository: kudu
Updated Branches:
  refs/heads/master 2adb3aeb1 -> 25d2efb06


Workaround KUDU-1580: bump negotiation timeout to 15sec

KUDU-1580 is a bug where RPC negotiation timeouts aren't considered
retriable errors. We see this cause issues on test clusters
occasionally.

Because fixing the bug is a bit trickier, let's bump the timeout for
1.1, and then drop it back down once the bug is addressed.

Change-Id: I98b246639882b2ea107648562a383f6b40b35390
Reviewed-on: http://gerrit.cloudera.org:8080/4977
Reviewed-by: Adar Dembo <adar@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <aserbin@cloudera.com>


Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/25d2efb0
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/25d2efb0
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/25d2efb0

Branch: refs/heads/master
Commit: 25d2efb064291601d87f6d6f89daa3548bbee62f
Parents: 2adb3ae
Author: Todd Lipcon <todd@apache.org>
Authored: Mon Nov 7 14:33:07 2016 -0800
Committer: Todd Lipcon <todd@apache.org>
Committed: Tue Nov 8 01:19:49 2016 +0000

----------------------------------------------------------------------
 src/kudu/rpc/reactor.cc | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kudu/blob/25d2efb0/src/kudu/rpc/reactor.cc
----------------------------------------------------------------------
diff --git a/src/kudu/rpc/reactor.cc b/src/kudu/rpc/reactor.cc
index 99aa2e6..adc6f1a 100644
--- a/src/kudu/rpc/reactor.cc
+++ b/src/kudu/rpc/reactor.cc
@@ -65,7 +65,10 @@ static const int kDefaultLibEvFlags = ev::AUTO;
 using std::string;
 using std::shared_ptr;
 
-DEFINE_int64(rpc_negotiation_timeout_ms, 3000,
+// TODO(KUDU-1580). This timeout has been bumped from 3 seconds up to
+// 15 seconds to workaround a bug. We should drop it back down when
+// KUDU-1580 is fixed.
+DEFINE_int64(rpc_negotiation_timeout_ms, 15000,
              "Timeout for negotiating an RPC connection.");
 TAG_FLAG(rpc_negotiation_timeout_ms, advanced);
 TAG_FLAG(rpc_negotiation_timeout_ms, runtime);


Mime
View raw message