Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 36690200BA5 for ; Tue, 4 Oct 2016 21:43:37 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 33468160AC7; Tue, 4 Oct 2016 19:43:37 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 80D3F160ACC for ; Tue, 4 Oct 2016 21:43:36 +0200 (CEST) Received: (qmail 54787 invoked by uid 500); 4 Oct 2016 19:43:35 -0000 Mailing-List: contact commits-help@kudu.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@kudu.apache.org Delivered-To: mailing list commits@kudu.apache.org Received: (qmail 54777 invoked by uid 99); 4 Oct 2016 19:43:35 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Oct 2016 19:43:35 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 6CD11E00DB; Tue, 4 Oct 2016 19:43:35 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: danburkert@apache.org To: commits@kudu.apache.org Date: Tue, 04 Oct 2016 19:43:36 -0000 Message-Id: <6cc0dcc024954e61a4acb62d26853025@git.apache.org> In-Reply-To: <0e7df68ce8c14b219e1e70458b0c5297@git.apache.org> References: <0e7df68ce8c14b219e1e70458b0c5297@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [2/2] kudu git commit: Reintroduce TSAN suppression for epoll_ctl archived-at: Tue, 04 Oct 2016 19:43:37 -0000 Reintroduce TSAN suppression for epoll_ctl Since 407f95da1254 a few spurious TSAN errors have surfaced from libev / epoll_ctl. See also: * An example race: https://gist.github.com/danburkert/869809cb91ba8cae4ff80c671a3bc232 * The original commit introducing a suppression on ev_ctl: https://gerrit.cloudera.org/#/c/1793/ Change-Id: Ic000dd66f05b67ff607602c5893f301808df3b4b Reviewed-on: http://gerrit.cloudera.org:8080/4618 Reviewed-by: Todd Lipcon Tested-by: Dan Burkert Project: http://git-wip-us.apache.org/repos/asf/kudu/repo Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/1a60ed7d Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/1a60ed7d Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/1a60ed7d Branch: refs/heads/master Commit: 1a60ed7d2dacc840aa28e43eaee29d26401941de Parents: 624a88b Author: Dan Burkert Authored: Tue Oct 4 11:22:36 2016 -0700 Committer: Dan Burkert Committed: Tue Oct 4 19:43:08 2016 +0000 ---------------------------------------------------------------------- build-support/tsan-suppressions.txt | 3 +++ 1 file changed, 3 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/kudu/blob/1a60ed7d/build-support/tsan-suppressions.txt ---------------------------------------------------------------------- diff --git a/build-support/tsan-suppressions.txt b/build-support/tsan-suppressions.txt index 4fa7f41..9a12e69 100644 --- a/build-support/tsan-suppressions.txt +++ b/build-support/tsan-suppressions.txt @@ -26,6 +26,9 @@ race:_ULx86_64_init race:_ULx86_64_local_addr_space_init +# libev uses some lock-free synchronization, but doesn't have TSAN annotations. +race:epoll_ctl + # TSAN complains about data races on the global signals variable in # ev_feed_signal and spoiled errno in ev_sighandler. Both are probably noise. race:ev_sighandler