kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From t...@apache.org
Subject [4/4] kudu git commit: client: bump scanner log messages to VLOG(2)
Date Thu, 06 Oct 2016 02:57:19 GMT
client: bump scanner log messages to VLOG(2)

We previously logged every scanner batch at VLOG(1) which is excessively
noisy.  Changing this improved the performance of Impala queries
significantly when Impala was running with --v=1.

Change-Id: Icb59c22e26abb7a01a93e088391a6a28e6397b69
Reviewed-on: http://gerrit.cloudera.org:8080/4641
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <aserbin@cloudera.com>


Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/cae2f989
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/cae2f989
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/cae2f989

Branch: refs/heads/master
Commit: cae2f98998629e682d5c6618b3a2854eec703fd4
Parents: 127438a
Author: Todd Lipcon <todd@apache.org>
Authored: Wed Oct 5 19:05:45 2016 -0700
Committer: Todd Lipcon <todd@apache.org>
Committed: Thu Oct 6 02:56:35 2016 +0000

----------------------------------------------------------------------
 src/kudu/client/client.cc           | 12 ++++++------
 src/kudu/client/scanner-internal.cc | 14 +++++++-------
 2 files changed, 13 insertions(+), 13 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kudu/blob/cae2f989/src/kudu/client/client.cc
----------------------------------------------------------------------
diff --git a/src/kudu/client/client.cc b/src/kudu/client/client.cc
index 58ee0d4..5c9f8a6 100644
--- a/src/kudu/client/client.cc
+++ b/src/kudu/client/client.cc
@@ -1186,13 +1186,13 @@ Status KuduScanner::Open() {
 
   if (data_->configuration().spec().CanShortCircuit() ||
       !data_->partition_pruner_.HasMorePartitionKeyRanges()) {
-    VLOG(1) << "Short circuiting scan " << ToString();
+    VLOG(2) << "Short circuiting scan " << ToString();
     data_->open_ = true;
     data_->short_circuit_ = true;
     return Status::OK();
   }
 
-  VLOG(1) << "Beginning scan " << ToString();
+  VLOG(2) << "Beginning scan " << ToString();
 
   MonoTime deadline = MonoTime::Now() + data_->configuration().timeout();
   set<string> blacklist;
@@ -1210,7 +1210,7 @@ Status KuduScanner::KeepAlive() {
 void KuduScanner::Close() {
   if (!data_->open_) return;
 
-  VLOG(1) << "Ending scan " << ToString();
+  VLOG(2) << "Ending scan " << ToString();
 
   // Close the scanner on the server-side, if necessary.
   //
@@ -1263,7 +1263,7 @@ Status KuduScanner::NextBatch(KuduScanBatch* batch) {
 
   if (data_->data_in_open_) {
     // We have data from a previous scan.
-    VLOG(1) << "Extracting data from scan " << ToString();
+    VLOG(2) << "Extracting data from scan " << ToString();
     data_->data_in_open_ = false;
     return batch->data_->Reset(&data_->controller_,
                                data_->configuration().projection(),
@@ -1271,7 +1271,7 @@ Status KuduScanner::NextBatch(KuduScanBatch* batch) {
                                 make_gscoped_ptr(data_->last_response_.release_data()));
   } else if (data_->last_response_.has_more_results()) {
     // More data is available in this tablet.
-    VLOG(1) << "Continuing scan " << ToString();
+    VLOG(2) << "Continuing scan " << ToString();
 
     MonoTime batch_deadline = MonoTime::Now() + data_->configuration().timeout();
     data_->PrepareRequest(KuduScanner::Data::CONTINUE);
@@ -1318,7 +1318,7 @@ Status KuduScanner::NextBatch(KuduScanBatch* batch) {
     // More data may be available in other tablets.
     // No need to close the current tablet; we scanned all the data so the
     // server closed it for us.
-    VLOG(1) << "Scanning next tablet " << ToString();
+    VLOG(2) << "Scanning next tablet " << ToString();
     data_->last_primary_key_.clear();
     MonoTime deadline = MonoTime::Now() + data_->configuration().timeout();
     set<string> blacklist;

http://git-wip-us.apache.org/repos/asf/kudu/blob/cae2f989/src/kudu/client/scanner-internal.cc
----------------------------------------------------------------------
diff --git a/src/kudu/client/scanner-internal.cc b/src/kudu/client/scanner-internal.cc
index 1c9252d..0ddc5de 100644
--- a/src/kudu/client/scanner-internal.cc
+++ b/src/kudu/client/scanner-internal.cc
@@ -272,7 +272,7 @@ Status KuduScanner::Data::OpenTablet(const string& partition_key,
   }
 
   if (last_primary_key_.length() > 0) {
-    VLOG(1) << "Setting NewScanRequestPB last_primary_key to hex value "
+    VLOG(2) << "Setting NewScanRequestPB last_primary_key to hex value "
         << HexDump(last_primary_key_);
     scan->set_last_primary_key(last_primary_key_);
   }
@@ -358,7 +358,7 @@ Status KuduScanner::Data::OpenTablet(const string& partition_key,
       blacklist->clear();
       int sleep_ms = attempt * 100;
       // TODO: should ensure that sleep_ms does not pass the provided deadline.
-      VLOG(1) << "Tablet " << remote_->tablet_id() << " current unavailable:
"
+      VLOG(1) << "Tablet " << remote_->tablet_id() << " currently unavailable:
"
               << lookup_status.ToString() << ". Sleeping for " << sleep_ms
<< "ms "
               << "and retrying...";
       SleepFor(MonoDelta::FromMilliseconds(sleep_ms));
@@ -386,12 +386,12 @@ Status KuduScanner::Data::OpenTablet(const string& partition_key,
   data_in_open_ = last_response_.has_data();
   if (last_response_.has_more_results()) {
     next_req_.set_scanner_id(last_response_.scanner_id());
-    VLOG(1) << "Opened tablet " << remote_->tablet_id()
+    VLOG(2) << "Opened tablet " << remote_->tablet_id()
             << ", scanner ID " << last_response_.scanner_id();
   } else if (last_response_.has_data()) {
-    VLOG(1) << "Opened tablet " << remote_->tablet_id() << ", no scanner
ID assigned";
+    VLOG(2) << "Opened tablet " << remote_->tablet_id() << ", no scanner
ID assigned";
   } else {
-    VLOG(1) << "Opened tablet " << remote_->tablet_id() << " (no rows),
no scanner ID assigned";
+    VLOG(2) << "Opened tablet " << remote_->tablet_id() << " (no rows),
no scanner ID assigned";
   }
 
   // If present in the response, set the snapshot timestamp and the encoded last
@@ -514,7 +514,7 @@ void KuduScanBatch::Data::ExtractRows(vector<KuduScanBatch::RowPtr>*
rows) {
 
   if (PREDICT_FALSE(n_rows == 0)) {
     // Early-out here to avoid a UBSAN failure.
-    VLOG(1) << "Extracted 0 rows";
+    VLOG(2) << "Extracted 0 rows";
     return;
   }
 
@@ -530,7 +530,7 @@ void KuduScanBatch::Data::ExtractRows(vector<KuduScanBatch::RowPtr>*
rows) {
     src += projected_row_size_;
     n_rows--;
   }
-  VLOG(1) << "Extracted " << rows->size() << " rows";
+  VLOG(2) << "Extracted " << rows->size() << " rows";
 }
 
 void KuduScanBatch::Data::Clear() {


Mime
View raw message