kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From danburk...@apache.org
Subject [2/2] kudu git commit: Reintroduce TSAN suppression for epoll_ctl
Date Tue, 04 Oct 2016 19:43:36 GMT
Reintroduce TSAN suppression for epoll_ctl

Since 407f95da1254 a few spurious TSAN errors have surfaced from libev /
epoll_ctl.

See also:

* An example race: https://gist.github.com/danburkert/869809cb91ba8cae4ff80c671a3bc232
* The original commit introducing a suppression on ev_ctl: https://gerrit.cloudera.org/#/c/1793/

Change-Id: Ic000dd66f05b67ff607602c5893f301808df3b4b
Reviewed-on: http://gerrit.cloudera.org:8080/4618
Reviewed-by: Todd Lipcon <todd@apache.org>
Tested-by: Dan Burkert <dan@cloudera.com>


Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/1a60ed7d
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/1a60ed7d
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/1a60ed7d

Branch: refs/heads/master
Commit: 1a60ed7d2dacc840aa28e43eaee29d26401941de
Parents: 624a88b
Author: Dan Burkert <dan@cloudera.com>
Authored: Tue Oct 4 11:22:36 2016 -0700
Committer: Dan Burkert <dan@cloudera.com>
Committed: Tue Oct 4 19:43:08 2016 +0000

----------------------------------------------------------------------
 build-support/tsan-suppressions.txt | 3 +++
 1 file changed, 3 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kudu/blob/1a60ed7d/build-support/tsan-suppressions.txt
----------------------------------------------------------------------
diff --git a/build-support/tsan-suppressions.txt b/build-support/tsan-suppressions.txt
index 4fa7f41..9a12e69 100644
--- a/build-support/tsan-suppressions.txt
+++ b/build-support/tsan-suppressions.txt
@@ -26,6 +26,9 @@
 race:_ULx86_64_init
 race:_ULx86_64_local_addr_space_init
 
+# libev uses some lock-free synchronization, but doesn't have TSAN annotations.
+race:epoll_ctl
+
 # TSAN complains about data races on the global signals variable in
 # ev_feed_signal and spoiled errno in ev_sighandler. Both are probably noise.
 race:ev_sighandler


Mime
View raw message