kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mpe...@apache.org
Subject [3/3] kudu git commit: Take 2: fix flakiness in tablet_history_gc-itest
Date Tue, 13 Sep 2016 00:28:04 GMT
Take 2: fix flakiness in tablet_history_gc-itest

3a9ea63b9f210b64124b2d9d2b5f14ed1214f272 attempted to fix this bug, but
I added the flag setting to the wrong test case. Take two, this time on
the test case that was actually flaky!

Change-Id: I669cac8a696c61e683485fec175d1241ee34410a
Reviewed-on: http://gerrit.cloudera.org:8080/4388
Tested-by: Kudu Jenkins
Reviewed-by: Mike Percy <mpercy@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/2628ec0d
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/2628ec0d
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/2628ec0d

Branch: refs/heads/master
Commit: 2628ec0d7c3362f94e000b021d3963a080ebd739
Parents: df5c7a1
Author: Todd Lipcon <todd@apache.org>
Authored: Mon Sep 12 12:48:13 2016 -0700
Committer: Mike Percy <mpercy@apache.org>
Committed: Tue Sep 13 00:27:01 2016 +0000

----------------------------------------------------------------------
 src/kudu/integration-tests/tablet_history_gc-itest.cc | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kudu/blob/2628ec0d/src/kudu/integration-tests/tablet_history_gc-itest.cc
----------------------------------------------------------------------
diff --git a/src/kudu/integration-tests/tablet_history_gc-itest.cc b/src/kudu/integration-tests/tablet_history_gc-itest.cc
index 9f3a335..7420d3a 100644
--- a/src/kudu/integration-tests/tablet_history_gc-itest.cc
+++ b/src/kudu/integration-tests/tablet_history_gc-itest.cc
@@ -68,9 +68,7 @@ class TabletHistoryGcITest : public MiniClusterITestBase {
 // Check that attempts to scan prior to the ancient history mark fail.
 TEST_F(TabletHistoryGcITest, TestSnapshotScanBeforeAHM) {
   FLAGS_tablet_history_max_age_sec = 0;
-  // Set high scanner TTL, since this test opens scanners and then waits for some
-  // time before reading from them.
-  FLAGS_scanner_ttl_ms = 1000 * 60 * 60 * 24;
+
   NO_FATALS(StartCluster());
 
   // Create a tablet so we can scan it.
@@ -346,6 +344,10 @@ TEST_F(RandomizedTabletHistoryGcITest, TestRandomHistoryGCWorkload) {
 
   LOG(INFO) << "Running " << FLAGS_test_num_rounds << " rounds";
 
+  // Set high scanner TTL, since this test opens scanners and then waits for some
+  // time before reading from them.
+  FLAGS_scanner_ttl_ms = 1000 * 60 * 60 * 24;
+
   StartCluster(1); // Start MiniCluster with a single tablet server.
   TestWorkload workload(cluster_.get());
   workload.set_num_replicas(1);


Mime
View raw message