kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From t...@apache.org
Subject kudu git commit: catalog manager: cleanup status messages
Date Mon, 08 Aug 2016 18:37:55 GMT
Repository: kudu
Updated Branches:
  refs/heads/master 5f98cdb8c -> d60923c91


catalog manager: cleanup status messages

We were using the protobuf 'DebugString' method to fill out status messages.
DebugString adds newlines to the output, which isn't necessary for these short
statuses. Switching to 'ShortDebugString' removes the newlines.

Change-Id: I09e728e4f1e012ebd468d2244d18b31f1fb7c16b
Reviewed-on: http://gerrit.cloudera.org:8080/3858
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <todd@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/d60923c9
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/d60923c9
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/d60923c9

Branch: refs/heads/master
Commit: d60923c910a105be42026accdef786e1d7046ef8
Parents: 5f98cdb
Author: Dan Burkert <dan@cloudera.com>
Authored: Sat Aug 6 18:05:50 2016 -0700
Committer: Todd Lipcon <todd@apache.org>
Committed: Mon Aug 8 18:37:48 2016 +0000

----------------------------------------------------------------------
 src/kudu/master/catalog_manager.cc | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kudu/blob/d60923c9/src/kudu/master/catalog_manager.cc
----------------------------------------------------------------------
diff --git a/src/kudu/master/catalog_manager.cc b/src/kudu/master/catalog_manager.cc
index babe43c..e8f0da5 100644
--- a/src/kudu/master/catalog_manager.cc
+++ b/src/kudu/master/catalog_manager.cc
@@ -983,7 +983,7 @@ Status CatalogManager::IsCreateTableDone(const IsCreateTableDoneRequestPB*
req,
   TRACE("Looking up table");
   RETURN_NOT_OK(FindTable(req->table(), &table));
   if (table == nullptr) {
-    Status s = Status::NotFound("The table does not exist", req->table().DebugString());
+    Status s = Status::NotFound("The table does not exist", req->table().ShortDebugString());
     SetupError(resp->mutable_error(), MasterErrorPB::TABLE_NOT_FOUND, s);
     return s;
   }
@@ -1057,7 +1057,7 @@ Status CatalogManager::DeleteTable(const DeleteTableRequestPB* req,
   scoped_refptr<TableInfo> table;
   RETURN_NOT_OK(FindTable(req->table(), &table));
   if (table == nullptr) {
-    Status s = Status::NotFound("The table does not exist", req->table().DebugString());
+    Status s = Status::NotFound("The table does not exist", req->table().ShortDebugString());
     SetupError(resp->mutable_error(), MasterErrorPB::TABLE_NOT_FOUND, s);
     return s;
   }
@@ -1210,7 +1210,7 @@ Status CatalogManager::ApplyAlterSchemaSteps(const SysTablesEntryPB&
current_pb,
       // TODO: EDIT_COLUMN
 
       default: {
-        return Status::InvalidArgument("Invalid alter schema step type", step.DebugString());
+        return Status::InvalidArgument("Invalid alter schema step type", step.ShortDebugString());
       }
     }
   }
@@ -1402,7 +1402,7 @@ Status CatalogManager::AlterTable(const AlterTableRequestPB* req,
   scoped_refptr<TableInfo> table;
   RETURN_NOT_OK(FindTable(req->table(), &table));
   if (table == nullptr) {
-    Status s = Status::NotFound("The table does not exist", req->table().DebugString());
+    Status s = Status::NotFound("The table does not exist", req->table().ShortDebugString());
     SetupError(resp->mutable_error(), MasterErrorPB::TABLE_NOT_FOUND, s);
     return s;
   }
@@ -1421,7 +1421,7 @@ Status CatalogManager::AlterTable(const AlterTableRequestPB* req,
     scoped_refptr<TableInfo> table_again;
     CHECK_OK(FindTable(req->table(), &table_again));
     if (table_again == nullptr) {
-      Status s = Status::NotFound("The table does not exist", req->table().DebugString());
+      Status s = Status::NotFound("The table does not exist", req->table().ShortDebugString());
       SetupError(resp->mutable_error(), MasterErrorPB::TABLE_NOT_FOUND, s);
       return s;
     }
@@ -1632,7 +1632,7 @@ Status CatalogManager::IsAlterTableDone(const IsAlterTableDoneRequestPB*
req,
   TRACE("Looking up table");
   RETURN_NOT_OK(FindTable(req->table(), &table));
   if (table == nullptr) {
-    Status s = Status::NotFound("The table does not exist", req->table().DebugString());
+    Status s = Status::NotFound("The table does not exist", req->table().ShortDebugString());
     SetupError(resp->mutable_error(), MasterErrorPB::TABLE_NOT_FOUND, s);
     return s;
   }
@@ -1660,7 +1660,7 @@ Status CatalogManager::GetTableSchema(const GetTableSchemaRequestPB*
req,
   TRACE("Looking up table");
   RETURN_NOT_OK(FindTable(req->table(), &table));
   if (table == nullptr) {
-    Status s = Status::NotFound("The table does not exist", req->table().DebugString());
+    Status s = Status::NotFound("The table does not exist", req->table().ShortDebugString());
     SetupError(resp->mutable_error(), MasterErrorPB::TABLE_NOT_FOUND, s);
     return s;
   }


Mime
View raw message