kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From t...@apache.org
Subject [2/2] kudu git commit: [docs] added tip on generic git commit guidelines
Date Mon, 29 Aug 2016 18:21:18 GMT
[docs] added tip on generic git commit guidelines

Change-Id: I5493723f7f0b337b73e3ef5ed4a7621fe5249927
Reviewed-on: http://gerrit.cloudera.org:8080/4115
Reviewed-by: Todd Lipcon <todd@apache.org>
Tested-by: Kudu Jenkins


Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/56aec48d
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/56aec48d
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/56aec48d

Branch: refs/heads/master
Commit: 56aec48db89084e6d9c6c3bbf6d2954160db3eea
Parents: 62fd254
Author: Alexey Serbin <aserbin@cloudera.com>
Authored: Wed Aug 24 12:02:59 2016 -0700
Committer: Todd Lipcon <todd@apache.org>
Committed: Mon Aug 29 02:12:58 2016 +0000

----------------------------------------------------------------------
 docs/contributing.adoc | 3 +++
 1 file changed, 3 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kudu/blob/56aec48d/docs/contributing.adoc
----------------------------------------------------------------------
diff --git a/docs/contributing.adoc b/docs/contributing.adoc
index 4451fc2..78e20ae 100644
--- a/docs/contributing.adoc
+++ b/docs/contributing.adoc
@@ -96,6 +96,9 @@ or to push a change to the `gh-pages` branch (to update the website):
 git push gerrit HEAD:refs/for/gh-pages --no-thin
 ----
 
+TIP: While preparing a patch for review, it's a good idea to follow
+link:https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project#_commit_guidelines[generic
git commit guidelines and good practices].
+
 NOTE: The `--no-thin` argument is a workaround to prevent an error in Gerrit. See
 https://code.google.com/p/gerrit/issues/detail?id=1582.
 


Mime
View raw message