kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mpe...@apache.org
Subject incubator-kudu git commit: Make block_manager-test work on systems without hole-punching
Date Mon, 18 Jul 2016 19:16:28 GMT
Repository: incubator-kudu
Updated Branches:
  refs/heads/master df1c7a5a4 -> 7e3794c47


Make block_manager-test work on systems without hole-punching

Commit 47c023f5eba708a184666e53d4a3000177a32fbc changed
block_manager-test so that it used a macro to return from tests that
weren't using the log block manager. This macro also needs to be
called in the Setup() method for BlockManagerTest<LogBlockManager>.

Change-Id: I56af74ad6b973c90057680be719b257109924fca
Reviewed-on: http://gerrit.cloudera.org:8080/3636
Tested-by: Kudu Jenkins
Reviewed-by: Mike Percy <mpercy@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/incubator-kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kudu/commit/7e3794c4
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kudu/tree/7e3794c4
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kudu/diff/7e3794c4

Branch: refs/heads/master
Commit: 7e3794c47959c2f106fbd59daaa702e9f7243a9f
Parents: df1c7a5
Author: Will Berkeley <wdberkeley@gmail.com>
Authored: Mon Jul 18 13:30:23 2016 -0400
Committer: Mike Percy <mpercy@apache.org>
Committed: Mon Jul 18 19:16:05 2016 +0000

----------------------------------------------------------------------
 src/kudu/fs/block_manager-test.cc | 7 +++++++
 1 file changed, 7 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/7e3794c4/src/kudu/fs/block_manager-test.cc
----------------------------------------------------------------------
diff --git a/src/kudu/fs/block_manager-test.cc b/src/kudu/fs/block_manager-test.cc
index 8674d5a..81af5b8 100644
--- a/src/kudu/fs/block_manager-test.cc
+++ b/src/kudu/fs/block_manager-test.cc
@@ -132,6 +132,13 @@ class BlockManagerTest : public KuduTest {
 };
 
 template <>
+void BlockManagerTest<LogBlockManager>::SetUp() {
+  RETURN_NOT_LOG_BLOCK_MANAGER();
+  CHECK_OK(bm_->Create());
+  CHECK_OK(bm_->Open());
+}
+
+template <>
 void BlockManagerTest<FileBlockManager>::RunMultipathTest(const vector<string>&
paths) {
   // Ensure that each path has an instance file and that it's well-formed.
   for (const string& path : paths) {


Mime
View raw message