kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mpe...@apache.org
Subject incubator-kudu git commit: Fix flakiness in RaftConsensusITest.TestMasterNotifiedOnConfigChange
Date Tue, 28 Jun 2016 20:07:18 GMT
Repository: incubator-kudu
Updated Branches:
  refs/heads/master 4cac79f3f -> e71b18fbf


Fix flakiness in RaftConsensusITest.TestMasterNotifiedOnConfigChange

This test was supposed to wait until the master had committed
a given operation, but in fact was only waiting until all of the
servers had _replicated_ the operation. In TSAN builds where things
ran slower, this caused it to be about 7% flaky.

The fix is to simply wait for the op to be committed, not just replicated.
With the fix, I looped it 100 times and it passed.

Change-Id: Ibb5875e8d4200b0058cf7e7c4ee04771b91d2a24
Reviewed-on: http://gerrit.cloudera.org:8080/3511
Tested-by: Todd Lipcon <todd@apache.org>
Reviewed-by: Mike Percy <mpercy@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/incubator-kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kudu/commit/e71b18fb
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kudu/tree/e71b18fb
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kudu/diff/e71b18fb

Branch: refs/heads/master
Commit: e71b18fbfa900a99023a0bdcc1b344c0b1b4c489
Parents: 4cac79f
Author: Todd Lipcon <todd@cloudera.com>
Authored: Mon Jun 27 14:20:51 2016 -0700
Committer: Mike Percy <mpercy@apache.org>
Committed: Tue Jun 28 20:02:46 2016 +0000

----------------------------------------------------------------------
 src/kudu/integration-tests/raft_consensus-itest.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/e71b18fb/src/kudu/integration-tests/raft_consensus-itest.cc
----------------------------------------------------------------------
diff --git a/src/kudu/integration-tests/raft_consensus-itest.cc b/src/kudu/integration-tests/raft_consensus-itest.cc
index 08a9249..9f27c76 100644
--- a/src/kudu/integration-tests/raft_consensus-itest.cc
+++ b/src/kudu/integration-tests/raft_consensus-itest.cc
@@ -2003,7 +2003,7 @@ TEST_F(RaftConsensusITest, TestMasterNotifiedOnConfigChange) {
   // Wait for initial NO_OP to be committed by the leader.
   TServerDetails* leader_ts;
   ASSERT_OK(FindTabletLeader(tablet_servers_, tablet_id, timeout, &leader_ts));
-  ASSERT_OK(WaitForServersToAgree(timeout, active_tablet_servers, tablet_id, 1));
+  ASSERT_OK(itest::WaitUntilCommittedOpIdIndexIs(1, leader_ts, tablet_id, timeout));
 
   // Change the config.
   TServerDetails* tserver_to_add = tablet_servers_[uuid_to_add];


Mime
View raw message