kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From a...@apache.org
Subject [2/2] incubator-kudu git commit: alter_schema_transaction: don't crash in ToString() when no timestamp
Date Thu, 23 Jun 2016 21:52:42 GMT
alter_schema_transaction: don't crash in ToString() when no timestamp

Saw this in a local alter_table-test failure.

I0623 14:17:50.224598 26418 transaction_tracker.cc:230] Dumping currently running transactions:
F0623 14:17:50.224697 26418 transaction.h:206] Check failed: timestamp_ != Timestamp::kInvalidTimestamp
*** Check failure stack trace: ***
    @     0x7f4bb399146d  google::LogMessage::Fail() at ??:0
    @     0x7f4bb39934d3  google::LogMessage::SendToLog() at ??:0
    @     0x7f4bb3990fca  google::LogMessage::Flush() at ??:0
    @     0x7f4bb3993f1f  google::LogMessageFatal::~LogMessageFatal() at ??:0
    @     0x7f4bb484e3f6  kudu::tablet::TransactionState::timestamp() at ??:0
    @     0x7f4bb489b804  kudu::tablet::AlterSchemaTransactionState::ToString() at ??:0
    @     0x7f4bb489c8f6  kudu::tablet::AlterSchemaTransaction::ToString() at ??:0
    @     0x7f4bb489f1fd  kudu::tablet::TransactionDriver::ToStringUnlocked() at ??:0
    @     0x7f4bb489f132  kudu::tablet::TransactionDriver::ToString() at ??:0
    @     0x7f4bb48a6790  kudu::tablet::TransactionTracker::WaitForAllToFinish() at ??:0
    @     0x7f4bb48a612c  kudu::tablet::TransactionTracker::WaitForAllToFinish() at ??:0
    @     0x7f4bb4891100  kudu::tablet::TabletPeer::Shutdown() at ??:0
    @     0x7f4bb4bfc993  kudu::tserver::TSTabletManager::Shutdown() at ??:0
    @     0x7f4bb4bd11a2  kudu::tserver::TabletServer::Shutdown() at ??:0
    @     0x7f4bb4b97e71  kudu::tserver::MiniTabletServer::Shutdown() at ??:0
    @     0x7f4bb4b97f8c  kudu::tserver::MiniTabletServer::Restart() at ??:0
    @           0x447c10  kudu::AlterTableTest::RestartTabletServer() at /home/adar/Source/kudu/src/kudu/integration-tests/alter_table-test.cc:159
    @           0x4312e3  kudu::AlterTableTest_TestRestartTSDuringAlter_Test::TestBody() at
/home/adar/Source/kudu/src/kudu/integration-tests/alter_table-test.cc:394 (discriminator 2)
    @     0x7f4bb4ebf0f7  testing::internal::HandleExceptionsInMethodIfSupported<>()
at ??:0
    @     0x7f4bb4eb5f92  testing::Test::Run() at ??:0
    @     0x7f4bb4eb60d8  testing::TestInfo::Run() at ??:0
    @     0x7f4bb4eb61b5  testing::TestCase::Run() at ??:0
    @     0x7f4bb4eb6be8  testing::internal::UnitTestImpl::RunAllTests() at ??:0
    @     0x7f4bb4ebf667  testing::internal::HandleExceptionsInMethodIfSupported<>()
at ??:0
    @     0x7f4bb4eb628d  testing::UnitTest::Run() at ??:0
    @     0x7f4bb4f6e226  RUN_ALL_TESTS() at ??:0
    @     0x7f4bb4f6dc89  main at ??:0
    @     0x7f4bb2a02830  __libc_start_main at ??:0
    @           0x42c689  _start at ??:?
    @              (nil)  (unknown)

Change-Id: I702aa5437dec54b93a78c9415d83be0d7d07c364
Reviewed-on: http://gerrit.cloudera.org:8080/3475
Reviewed-by: David Ribeiro Alves <dralves@apache.org>
Tested-by: Kudu Jenkins


Project: http://git-wip-us.apache.org/repos/asf/incubator-kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kudu/commit/194c9a0f
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kudu/tree/194c9a0f
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kudu/diff/194c9a0f

Branch: refs/heads/master
Commit: 194c9a0f7cd8b0955c13ebc9ab321e6190de9acb
Parents: e45fc7b
Author: Adar Dembo <adar@cloudera.com>
Authored: Thu Jun 23 14:26:28 2016 -0700
Committer: Adar Dembo <adar@cloudera.com>
Committed: Thu Jun 23 21:52:11 2016 +0000

----------------------------------------------------------------------
 src/kudu/tablet/transactions/alter_schema_transaction.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/194c9a0f/src/kudu/tablet/transactions/alter_schema_transaction.cc
----------------------------------------------------------------------
diff --git a/src/kudu/tablet/transactions/alter_schema_transaction.cc b/src/kudu/tablet/transactions/alter_schema_transaction.cc
index c9d334f..4c81530 100644
--- a/src/kudu/tablet/transactions/alter_schema_transaction.cc
+++ b/src/kudu/tablet/transactions/alter_schema_transaction.cc
@@ -45,7 +45,7 @@ using tserver::AlterSchemaResponsePB;
 string AlterSchemaTransactionState::ToString() const {
   return Substitute("AlterSchemaTransactionState "
                     "[timestamp=$0, schema=$1, request=$2]",
-                    timestamp().ToString(),
+                    has_timestamp() ? timestamp().ToString() : "<unassigned>",
                     schema_ == nullptr ? "(none)" : schema_->ToString(),
                     request_ == nullptr ? "(none)" : request_->ShortDebugString());
 }


Mime
View raw message