kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mpe...@apache.org
Subject [3/3] incubator-kudu git commit: Add more helpful CHECK message at master startup
Date Thu, 16 Jun 2016 22:39:57 GMT
Add more helpful CHECK message at master startup

Maybe this could help debug KUDU-1488 a little bit

Change-Id: I86b5c9d9553b251c289b51bddfe3f84beaa489e9
Reviewed-on: http://gerrit.cloudera.org:8080/3396
Reviewed-by: Jean-Daniel Cryans
Tested-by: Mike Percy <mpercy@apache.org>


Project: http://git-wip-us.apache.org/repos/asf/incubator-kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kudu/commit/99f4be13
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kudu/tree/99f4be13
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kudu/diff/99f4be13

Branch: refs/heads/master
Commit: 99f4be13d81b4bb7d5db2f78f465ff61a390a3db
Parents: ee4fc9f
Author: Mike Percy <mpercy@apache.org>
Authored: Tue Jun 14 14:47:01 2016 -0700
Committer: Mike Percy <mpercy@apache.org>
Committed: Thu Jun 16 22:39:32 2016 +0000

----------------------------------------------------------------------
 src/kudu/master/sys_catalog.cc | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/99f4be13/src/kudu/master/sys_catalog.cc
----------------------------------------------------------------------
diff --git a/src/kudu/master/sys_catalog.cc b/src/kudu/master/sys_catalog.cc
index 0a968e5..dbcc4c6 100644
--- a/src/kudu/master/sys_catalog.cc
+++ b/src/kudu/master/sys_catalog.cc
@@ -456,7 +456,9 @@ Status SysCatalogTable::VisitTables(TableVisitor* visitor) {
 
   const int8_t tables_entry = TABLES_ENTRY;
   const int type_col_idx = schema_.find_column(kSysCatalogTableColType);
-  CHECK(type_col_idx != Schema::kColumnNotFound);
+  CHECK(type_col_idx != Schema::kColumnNotFound)
+      << "Cannot find sys catalog table column " << kSysCatalogTableColType <<
" in schema: "
+      << schema_.ToString();
 
   auto pred_tables = ColumnPredicate::Equality(schema_.column(type_col_idx), &tables_entry);
   ScanSpec spec;


Mime
View raw message