kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From t...@apache.org
Subject [2/2] incubator-kudu git commit: tsan: remove two old suppressions
Date Wed, 22 Jun 2016 20:21:45 GMT
tsan: remove two old suppressions

This removes two TSAN suppressions which have been in the list since the
very first TSAN commit. I went back and looked at that code review and
can't find any explanation for them, and initial local testing with them
removed doesn't seem to turn anything up.

Maybe we've since addressed these and just didn't remove them. Let's
remove them, and if we start to see any TSAN flakes due to them, we can
add them back with an appropriate comment explaining why they're
required.

Change-Id: I25354ce37300ba495aa73909b6a2ba3672f22906
Reviewed-on: http://gerrit.cloudera.org:8080/3411
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <adar@cloudera.com>


Project: http://git-wip-us.apache.org/repos/asf/incubator-kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kudu/commit/4983a798
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kudu/tree/4983a798
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kudu/diff/4983a798

Branch: refs/heads/master
Commit: 4983a79827a8b674fe139250b7171d361e1b47b9
Parents: 869d520
Author: Todd Lipcon <todd@cloudera.com>
Authored: Mon Jun 20 11:55:27 2016 -0700
Committer: Todd Lipcon <todd@apache.org>
Committed: Wed Jun 22 20:18:25 2016 +0000

----------------------------------------------------------------------
 build-support/tsan-suppressions.txt | 2 --
 1 file changed, 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/4983a798/build-support/tsan-suppressions.txt
----------------------------------------------------------------------
diff --git a/build-support/tsan-suppressions.txt b/build-support/tsan-suppressions.txt
index 059d55f..e492b65 100644
--- a/build-support/tsan-suppressions.txt
+++ b/build-support/tsan-suppressions.txt
@@ -14,8 +14,6 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-race:_dl_deallocate_tls
-race:kudu::tablet::ScopedRowLock::Release
 
 # libunwind uses some double-checked locking which isn't perfectly safe.
 # Reported at http://savannah.nongnu.org/bugs/index.php?42677


Mime
View raw message