kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From t...@apache.org
Subject [2/3] incubator-kudu git commit: Address post-commit review comments on http://gerrit.cloudera.org:8080/#/c/3027
Date Fri, 13 May 2016 00:04:29 GMT
Address post-commit review comments on http://gerrit.cloudera.org:8080/#/c/3027

This just addresses some minor post-commit review comments. It doesn't introduce
any functional changes

Change-Id: If17e9fb99251823fb3d72ecfb4da48a647d7067e
Reviewed-on: http://gerrit.cloudera.org:8080/3052
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <adar@cloudera.com>


Project: http://git-wip-us.apache.org/repos/asf/incubator-kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kudu/commit/6774d361
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kudu/tree/6774d361
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kudu/diff/6774d361

Branch: refs/heads/master
Commit: 6774d361927da77b8d21e2c76270fabad10a5e3c
Parents: 2c0f805
Author: David Alves <david.alves@cloudera.com>
Authored: Thu May 12 14:12:12 2016 -0700
Committer: David Ribeiro Alves <david.alves@cloudera.com>
Committed: Thu May 12 23:49:30 2016 +0000

----------------------------------------------------------------------
 src/kudu/client/client-test.cc | 9 +++------
 src/kudu/util/net/net_util.cc  | 2 +-
 2 files changed, 4 insertions(+), 7 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/6774d361/src/kudu/client/client-test.cc
----------------------------------------------------------------------
diff --git a/src/kudu/client/client-test.cc b/src/kudu/client/client-test.cc
index 9c98d79..6aec3a7 100644
--- a/src/kudu/client/client-test.cc
+++ b/src/kudu/client/client-test.cc
@@ -1551,12 +1551,9 @@ TEST_F(ClientTest, TestFailedDnsResolution) {
   }
 
   // Now re-enable dns resolution, the write should succeed.
-  {
-    google::FlagSaver saver;
-    FLAGS_fail_dns_resolution = false;
-    ASSERT_OK(ApplyInsertToSession(session.get(), client_table_, 1, 1, "row"));
-    ASSERT_OK(session->Flush());
-  }
+  FLAGS_fail_dns_resolution = false;
+  ASSERT_OK(ApplyInsertToSession(session.get(), client_table_, 1, 1, "row"));
+  ASSERT_OK(session->Flush());
 }
 
 // Test which does an async flush and then drops the reference

http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/6774d361/src/kudu/util/net/net_util.cc
----------------------------------------------------------------------
diff --git a/src/kudu/util/net/net_util.cc b/src/kudu/util/net/net_util.cc
index e2613f8..0cb5101 100644
--- a/src/kudu/util/net/net_util.cc
+++ b/src/kudu/util/net/net_util.cc
@@ -48,7 +48,7 @@
 #define HOST_NAME_MAX 64
 #endif
 
-DEFINE_bool(fail_dns_resolution, false, "Wether to fail all dns resolution, for tests.");
+DEFINE_bool(fail_dns_resolution, false, "Whether to fail all dns resolution, for tests.");
 TAG_FLAG(fail_dns_resolution, hidden);
 
 using std::unordered_set;


Mime
View raw message