kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From t...@apache.org
Subject incubator-kudu git commit: Fix typo in comment in Flume sink
Date Sat, 23 Apr 2016 00:19:57 GMT
Repository: incubator-kudu
Updated Branches:
  refs/heads/master b6bab2092 -> aa9bf3a6a


Fix typo in comment in Flume sink

Also clarify some of the error handling semantics since this is a prime
example of Java client error handling that we can point people to.

Change-Id: Ibf61798e804df0b4988bb95620ca0180d97ebfe5
Reviewed-on: http://gerrit.cloudera.org:8080/2831
Tested-by: Kudu Jenkins
Reviewed-by: Jean-Daniel Cryans


Project: http://git-wip-us.apache.org/repos/asf/incubator-kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kudu/commit/aa9bf3a6
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kudu/tree/aa9bf3a6
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kudu/diff/aa9bf3a6

Branch: refs/heads/master
Commit: aa9bf3a6ab28d5facfaf0c129ce6d3deaafffdc9
Parents: b6bab20
Author: Mike Percy <mpercy@apache.org>
Authored: Thu Apr 21 02:50:00 2016 -0700
Committer: Jean-Daniel Cryans <jdcryans@gerrit.cloudera.org>
Committed: Fri Apr 22 03:14:41 2016 +0000

----------------------------------------------------------------------
 .../src/main/java/org/kududb/flume/sink/KuduSink.java | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/aa9bf3a6/java/kudu-flume-sink/src/main/java/org/kududb/flume/sink/KuduSink.java
----------------------------------------------------------------------
diff --git a/java/kudu-flume-sink/src/main/java/org/kududb/flume/sink/KuduSink.java b/java/kudu-flume-sink/src/main/java/org/kududb/flume/sink/KuduSink.java
index a6ed7bd..080cda2 100644
--- a/java/kudu-flume-sink/src/main/java/org/kududb/flume/sink/KuduSink.java
+++ b/java/kudu-flume-sink/src/main/java/org/kududb/flume/sink/KuduSink.java
@@ -232,12 +232,14 @@ public class KuduSink extends AbstractSink implements Configurable {
       List<OperationResponse> responses = session.flush();
       if (responses != null) {
         for (OperationResponse response : responses) {
-          // Only throw an EventDeliveryException if at least one of the responses was
-          // not a row error. Row errors can occur for example when an event is inserted
-          // into Kudu successfully as part of a transaction but the transaction is
-          // rolled back and a subsequent replay of the Flume transaction leads to a
-          // row error due to the fact that the row already exists (Kudu doesn't support
-          // "insert or overwrite" semantics yet).
+          // Throw an EventDeliveryException if at least one of the responses was
+          // a row error. Row errors can occur for example when an event is inserted
+          // into Kudu successfully but the Flume transaction is rolled back for some reason,
+          // and a subsequent replay of the same Flume transaction leads to a
+          // duplicate key error since the row already exists in Kudu.
+          // (Kudu doesn't support "insert or overwrite" semantics yet.)
+          // Note: Duplicate keys will not be reported as errors if ignoreDuplicateRows
+          // is enabled in the config.
           if (response.hasRowError()) {
             throw new EventDeliveryException("Failed to flush one or more changes. " +
                 "Transaction rolled back: " + response.getRowError().toString());


Mime
View raw message