kudu-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From t...@apache.org
Subject incubator-kudu git commit: transaction: reduce initial arena block size
Date Wed, 20 Apr 2016 22:10:30 GMT
Repository: incubator-kudu
Updated Branches:
  refs/heads/master fd0f6f398 -> 2eba21c93


transaction: reduce initial arena block size

Currently transactions start with a 32KB arena. This allocation
is large enough that it will often have to go to the tcmalloc central
free list and cause contention.

In practice, many use cases perform lots of small writes with only
a few operations per batch. In these cases, 32KB is way more than
will be needed in the arena. Starting with a 1KB arena block should
be sufficient.

Change-Id: I9250ffb7afd87c274ea29e1d1bf8daf6cafb8f28
Reviewed-on: http://gerrit.cloudera.org:8080/2753
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <adar@cloudera.com>


Project: http://git-wip-us.apache.org/repos/asf/incubator-kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-kudu/commit/2eba21c9
Tree: http://git-wip-us.apache.org/repos/asf/incubator-kudu/tree/2eba21c9
Diff: http://git-wip-us.apache.org/repos/asf/incubator-kudu/diff/2eba21c9

Branch: refs/heads/master
Commit: 2eba21c933b4b2628eb9a1a3a9a2a9c53cbeb866
Parents: fd0f6f3
Author: Todd Lipcon <todd@apache.org>
Authored: Mon Apr 11 10:35:34 2016 -0700
Committer: Todd Lipcon <todd@apache.org>
Committed: Wed Apr 20 22:09:08 2016 +0000

----------------------------------------------------------------------
 src/kudu/tablet/transactions/transaction.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-kudu/blob/2eba21c9/src/kudu/tablet/transactions/transaction.cc
----------------------------------------------------------------------
diff --git a/src/kudu/tablet/transactions/transaction.cc b/src/kudu/tablet/transactions/transaction.cc
index 508d8f1..5a0f737 100644
--- a/src/kudu/tablet/transactions/transaction.cc
+++ b/src/kudu/tablet/transactions/transaction.cc
@@ -32,7 +32,7 @@ TransactionState::TransactionState(TabletPeer* tablet_peer)
     : tablet_peer_(tablet_peer),
       completion_clbk_(new TransactionCompletionCallback()),
       timestamp_error_(0),
-      arena_(32 * 1024, 4 * 1024 * 1024),
+      arena_(1024, 4 * 1024 * 1024),
       external_consistency_mode_(CLIENT_PROPAGATED) {
 }
 


Mime
View raw message